From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luis Henriques Subject: Re: [net PATCH] atl1c: Fix misuse of netdev_alloc_skb in refilling rx ring Date: Sat, 27 Jul 2013 17:25:17 +0100 Message-ID: <87hafgrmvm.fsf@canonical.com> References: <1374857234-1442-1-git-send-email-nhorman@tuxdriver.com> <8761vxfefj.fsf@canonical.com> <20130726170251.GC11633@hmsreliant.think-freely.org> <20130726.155618.987909338861687509.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain Cc: nhorman@tuxdriver.com, netdev@vger.kernel.org, jcliburn@gmail.com, stable@vger.kernel.org To: David Miller Return-path: In-Reply-To: <20130726.155618.987909338861687509.davem@davemloft.net> (David Miller's message of "Fri, 26 Jul 2013 15:56:18 -0700 (PDT)") Sender: stable-owner@vger.kernel.org List-Id: netdev.vger.kernel.org David Miller writes: > From: Neil Horman > Date: Fri, 26 Jul 2013 13:02:51 -0400 > >> On Fri, Jul 26, 2013 at 05:56:16PM +0100, Luis Henriques wrote: >>> Neil Horman writes: >>> >>> > atl1c uses netdev_alloc_skb to refill its rx dma ring, but that call makes no >>> > guarantees about the suitability of the memory for use in DMA. As a result >>> > we've gotten reports of atl1c drivers occasionally hanging and needing to be >>> > reset: >>> > https://bugzilla.kernel.org/show_bug.cgi?id=54021 >>> > >>> > Fix this by modifying the call to use the internal version __netdev_alloc_skb, >>> > where you can set the gfp_mask explicitly to include GFP_DMA. >>> > >>> > Tested by two reporters in the above bug, who have the hardware to validate it. >>> > Both report immediate cessation of the problem with this patch >>> > >>> > Signed-off-by: Neil Horman >>> > CC: Jay Cliburn >>> > CC: "David S. Miller" >>> > CC: stable@vger.kernel.org >>> > Tested-by: Luis Henrix >>> >>> Thanks Neil! >>> >>> Would it be possible for you to update my name and email? (I've just >>> updated my bz account to remove my gmail account address -- I thought >>> I had done this ages ago.) >>> >>> Tested-by: Luis Henriques >>> >> I'm sure if Dave has time, he will square that up. > > I took care of this while applying Neil's patch, thanks. Thanks! Cheers, -- Luis