From: "Bjørn Mork" <bjorn@mork.no>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: <joseph.lutz@novatechweb.com>, <netdev@vger.kernel.org>
Subject: Re: Issue with Micrel PCI Network Driver.
Date: Tue, 12 Feb 2013 11:10:59 +0100 [thread overview]
Message-ID: <87halhkfkc.fsf@nemi.mork.no> (raw)
In-Reply-To: <1360604823.2701.11.camel@bwh-desktop.uk.solarflarecom.com> (Ben Hutchings's message of "Mon, 11 Feb 2013 17:47:03 +0000")
Ben Hutchings <bhutchings@solarflare.com> writes:
> On Mon, 2013-02-11 at 17:46 +0000, Ben Hutchings wrote:
>> On Fri, 2013-02-08 at 17:17 -0600, Joseph Lutz wrote:
>> > I am having an issue with one of the network interface drivers. The
>> > driver in question is 'drivers/net/ethernet/micrel/ksz884x.c', the
>> > driver for the Micrel-Kendin device 8841.
>> > I am trying to get systemd to rename the three network interfaces in my
>> > embedded atom system. I have one of the interfaces being renamed (an
>> > Intel Corporation 82574L), but the two Micrel interfaces are not being
>> > renamed. I traced this down to the driver not populating the
>> > /sys/devices/pci* information. Instead it places the driver into
>> > /sys/devices/virtual/net/.
>> [...]
>>
>> Right, this driver doesn't specify the parent device (PCI device) for
>> the net devices it creates.
>>
>> All you should need to is add:
>> SET_NETDEV_DEV(dev, pdev);
>> underneath the call to alloc_etherdev().
>
> Or rather:
> SET_NETDEV_DEV(dev, &pdev->dev);
That should of course be fixed. But this bug should not prevent
userspace from renaming the device, should it? Sounds like a userspace
application making too many stupid assumptions to me. Does it work for
network devices attached to other buses?
Bjørn
next prev parent reply other threads:[~2013-02-12 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 23:17 Issue with Micrel PCI Network Driver Joseph Lutz
2013-02-11 17:46 ` Ben Hutchings
2013-02-11 17:47 ` Ben Hutchings
2013-02-12 10:10 ` Bjørn Mork [this message]
2013-02-12 12:07 ` Ben Hutchings
2013-02-12 12:40 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87halhkfkc.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=bhutchings@solarflare.com \
--cc=joseph.lutz@novatechweb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).