From: Kevin Hilman <khilman@deeprootsystems.com>
To: Chaithrika U S <chaithrika@ti.com>
Cc: netdev@vger.kernel.org, davinci-linux-open-source@linux.davincidsp.com
Subject: Re: [PATCH] TI DaVinci EMAC : Fix rmmod error
Date: Fri, 19 Jun 2009 13:54:12 -0700 [thread overview]
Message-ID: <87hbyct05n.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1245238134-23512-1-git-send-email-chaithrika@ti.com> (Chaithrika U. S.'s message of "Wed\, 17 Jun 2009 07\:28\:54 -0400")
Chaithrika U S <chaithrika@ti.com> writes:
> clk_disable was called twice in the remove function.
> Correct this so that the driver module unloads without error.
>
> Signed-off-by: Chaithrika U S <chaithrika@ti.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
(TI DaVinci arch maintainer)
Will pull into DaVinci git until it merges upstream.
Kevin
> ---
> Applies to Linus' kernel tree
>
> drivers/net/davinci_emac.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 0e9b9f9..2df8fb0 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -2767,7 +2767,6 @@ static int __devexit davinci_emac_remove(struct platform_device *pdev)
>
> dev_notice(&ndev->dev, "DaVinci EMAC: davinci_emac_remove()\n");
>
> - clk_disable(emac_clk);
> platform_set_drvdata(pdev, NULL);
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> mdiobus_unregister(priv->mii_bus);
> --
> 1.5.6
>
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source@linux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
prev parent reply other threads:[~2009-06-19 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 11:28 [PATCH] TI DaVinci EMAC : Fix rmmod error Chaithrika U S
2009-06-19 20:54 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hbyct05n.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=chaithrika@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).