kernel panic with b44 and netifd

kernel panic with b44 and netifd

[Peter Münster]

Hi,

Unfortunately linux-5.15.153 crashes on my router when netifd is
running.

Further information and a patch are here:
https://github.com/openwrt/openwrt/issues/13789#issuecomment-1944799389

Could you please fix b44.c in linux-5.15?

Thanks in advance for your efforts. Kind regards,
-- 
           Peter

Re: kernel panic with b44 and netifd

[Michael Chan]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

On Wed, Apr 3, 2024 at 7:13 AM Peter Münster <pm@a16n.net> wrote:
>
> Hi,
>
> Unfortunately linux-5.15.153 crashes on my router when netifd is
> running.
>
> Further information and a patch are here:
> https://github.com/openwrt/openwrt/issues/13789#issuecomment-1944799389
>
> Could you please fix b44.c in linux-5.15?
>
Since you already have the patch, please post the patch to netdev for
review.  After the patch is accepted, it can then be back ported to
the stable trees.  Thanks.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

Re: kernel panic with b44 and netifd

[Peter Münster]

[-- Attachment #1.1: Type: text/plain, Size: 285 bytes --]

On Wed, Apr 03 2024, Michael Chan wrote:

> please post the patch to netdev for review.

Ok, please find it here attached.

And please consider also KanjiMonster’s comment here:
https://github.com/openwrt/openwrt/issues/13789#issuecomment-2034601851

-- 
           Peter

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: b44.patch --]
[-- Type: text/x-patch, Size: 831 bytes --]

--- build_dir/target-mipsel_mips32_musl/linux-bcm47xx_legacy/linux-5.15.153/drivers/net/ethernet/broadcom/b44.c~	2024-04-03 10:04:09.177021530 +0200
+++ build_dir/target-mipsel_mips32_musl/linux-bcm47xx_legacy/linux-5.15.153/drivers/net/ethernet/broadcom/b44.c	2024-04-03 10:46:42.267884445 +0200
@@ -2056,12 +2056,14 @@
 		bp->flags |= B44_FLAG_TX_PAUSE;
 	else
 		bp->flags &= ~B44_FLAG_TX_PAUSE;
-	if (bp->flags & B44_FLAG_PAUSE_AUTO) {
-		b44_halt(bp);
-		b44_init_rings(bp);
-		b44_init_hw(bp, B44_FULL_RESET);
-	} else {
-		__b44_set_flow_ctrl(bp, bp->flags);
+	if (netif_running(dev)) {
+		if (bp->flags & B44_FLAG_PAUSE_AUTO) {
+			b44_halt(bp);
+			b44_init_rings(bp);
+			b44_init_hw(bp, B44_FULL_RESET);
+		} else {
+			__b44_set_flow_ctrl(bp, bp->flags);
+		}
 	}
 	spin_unlock_irq(&bp->lock);
 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: kernel panic with b44 and netifd

[Florian Fainelli]

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

On 4/3/24 08:50, Peter Münster wrote:
> On Wed, Apr 03 2024, Michael Chan wrote:
> 
>> please post the patch to netdev for review.
> 
> Ok, please find it here attached.
> 
> And please consider also KanjiMonster’s comment here:
> https://github.com/openwrt/openwrt/issues/13789#issuecomment-2034601851
> 

This is not the proper way to post the patch, please follow the 
guidelines documented here:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst

and here:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-netdev.rst
-- 
Florian


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]