From: Petr Machata <petrm@nvidia.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Petr Machata <petrm@nvidia.com>, David Ahern <dsahern@kernel.org>,
<netdev@vger.kernel.org>, Ido Schimmel <idosch@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>, <mlxsw@nvidia.com>
Subject: Re: [PATCH iproute2-next v2 2/4] ip: ipnexthop: Support dumping next hop group stats
Date: Fri, 15 Mar 2024 12:15:51 +0100 [thread overview]
Message-ID: <87il1nkalr.fsf@nvidia.com> (raw)
In-Reply-To: <20240314085143.251f10be@hermes.local>
Stephen Hemminger <stephen@networkplumber.org> writes:
> On Thu, 14 Mar 2024 15:52:13 +0100
> Petr Machata <petrm@nvidia.com> wrote:
>
>> Next hop group stats allow verification of balancedness of a next hop
>> group. The feature was merged in kernel commit 7cf497e5a122 ("Merge branch
>> 'nexthop-group-stats'"). Add to ip the corresponding support. The
>> statistics are requested if "ip nexthop" is started with -s.
>>
>> Signed-off-by: Petr Machata <petrm@nvidia.com>
>
> Checkpatch complains:
>
> WARNING: braces {} are not necessary for single statement blocks
> #273: FILE: ip/ipnexthop.c:568:
> + if (show_stats) {
> + op_flags |= NHA_OP_FLAG_DUMP_STATS;
> + }
>
> total: 0 erro
Yes. The next patch adds more code to that branch.
next prev parent reply other threads:[~2024-03-15 11:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 14:52 [PATCH iproute2-next v2 0/4] Support for nexthop group statistics Petr Machata
2024-03-14 14:52 ` [PATCH iproute2-next v2 1/4] libnetlink: Add rta_getattr_uint() Petr Machata
2024-03-14 14:52 ` [PATCH iproute2-next v2 2/4] ip: ipnexthop: Support dumping next hop group stats Petr Machata
2024-03-14 15:51 ` Stephen Hemminger
2024-03-15 11:15 ` Petr Machata [this message]
2024-03-14 14:52 ` [PATCH iproute2-next v2 3/4] ip: ipnexthop: Support dumping next hop group HW stats Petr Machata
2024-03-14 14:52 ` [PATCH iproute2-next v2 4/4] ip: ipnexthop: Allow toggling collection of nexthop group HW statistics Petr Machata
2024-03-15 15:10 ` [PATCH iproute2-next v2 0/4] Support for nexthop group statistics patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il1nkalr.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=dsahern@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).