From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Hariprasad Kelam <hkelam@marvell.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<sgoutham@marvell.com>, <lcherian@marvell.com>,
<gakula@marvell.com>, <jerinj@marvell.com>, <sbhatta@marvell.com>,
Maxim Mikityanskiy <maxtram95@gmail.com>
Subject: Re: [net-next PATCH 0/5] octeontx2-pf: HTB offload support
Date: Thu, 12 Jan 2023 22:20:06 -0800 [thread overview]
Message-ID: <87ilhbx8fd.fsf@nvidia.com> (raw)
In-Reply-To: <20230112210738.72393731@kernel.org> (Jakub Kicinski's message of "Thu, 12 Jan 2023 21:07:38 -0800")
CCed Maxim Mikityanskiy since he has authored and done an extensive
amount of work on HTB offload support.
On Thu, 12 Jan, 2023 21:07:38 -0800 Jakub Kicinski <kuba@kernel.org> wrote:
> On Thu, 12 Jan 2023 23:01:15 +0530 Hariprasad Kelam wrote:
>> octeontx2 silicon and CN10K transmit interface consists of five
>> transmit levels starting from MDQ, TL4 to TL1. Once packets are
>> submitted to MDQ, hardware picks all active MDQs using strict
>> priority, and MDQs having the same priority level are chosen using
>> round robin. Each packet will traverse MDQ, TL4 to TL1 levels.
>> Each level contains an array of queues to support scheduling and
>> shaping.
>>
>> As HTB supports classful queuing mechanism by supporting rate and
>> ceil and allow the user to control the absolute bandwidth to
>> particular classes of traffic the same can be achieved by
>> configuring shapers and schedulers on different transmit levels.
>>
>> This series of patches adds support for HTB offload,
>>
>> Patch1: Allow strict priority parameter in HTB offload mode.
>>
>> Patch2: defines APIs such that the driver can dynamically initialize/
>> deinitialize the send queues.
>>
>> Patch3: Refactors transmit alloc/free calls as preparation for QOS
>> offload code.
>>
>> Patch4: Adds devlink support for the user to configure round-robin
>> priority at TL1
>>
>> Patch5: Adds actual HTB offload support.
>
> Rahul, since you're working on fixing the HTB offload warn -
> would you mind reviewing this series?
>
> https://lore.kernel.org/all/20230112173120.23312-1-hkelam@marvell.com/
I will take a look at the series and respond to the components I can
verify.
prev parent reply other threads:[~2023-01-13 6:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 17:31 [net-next PATCH 0/5] octeontx2-pf: HTB offload support Hariprasad Kelam
2023-01-12 17:31 ` [net-next PATCH 1/5] sch_htb: Allow HTB priority parameter in offload mode Hariprasad Kelam
2023-01-13 12:19 ` Maxim Mikityanskiy
2023-01-13 21:06 ` Rahul Rameshbabu
2023-01-14 1:50 ` Maxim Mikityanskiy
2023-01-14 2:18 ` Rahul Rameshbabu
2023-01-16 11:27 ` Maxim Mikityanskiy
2023-01-16 5:18 ` Hariprasad Kelam
2023-01-18 4:31 ` Rahul Rameshbabu
2023-01-12 17:31 ` [net-next PATCH 2/5] octeontx2-pf: qos send queues management Hariprasad Kelam
2023-01-12 17:31 ` [net-next PATCH 3/5] octeontx2-pf: Refactor schedular queue alloc/free calls Hariprasad Kelam
2023-01-12 17:31 ` [net-next PATCH 4/5] octeontx2-pf: Add devlink support to configure TL1 RR_PRIO Hariprasad Kelam
2023-01-13 12:19 ` Maxim Mikityanskiy
2023-01-12 17:31 ` [net-next PATCH 5/5] octeontx2-pf: Add support for HTB offload Hariprasad Kelam
2023-01-13 12:18 ` Maxim Mikityanskiy
2023-01-13 5:07 ` [net-next PATCH 0/5] octeontx2-pf: HTB offload support Jakub Kicinski
2023-01-13 6:20 ` Rahul Rameshbabu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilhbx8fd.fsf@nvidia.com \
--to=rrameshbabu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxtram95@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).