From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A1EBC43334 for ; Fri, 8 Jul 2022 05:03:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237032AbiGHFDU (ORCPT ); Fri, 8 Jul 2022 01:03:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237363AbiGHFDS (ORCPT ); Fri, 8 Jul 2022 01:03:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BE26796A7; Thu, 7 Jul 2022 22:03:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8E70162457; Fri, 8 Jul 2022 05:03:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88AF9C341C0; Fri, 8 Jul 2022 05:03:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657256596; bh=mIw7w2fyivOY9oNMtVB4mvNGbmUMA8pOqVREkwcUyFY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=t9AlP0F738ASocn9YUAkInLJoOVPzZzioRjDqRTTpLncyMorLKLD0yz3vpX+wdIkE 7o4AT3gFsJbqCgl7KGNZrXIZ3K1Gxu9EzDdgUWJSZQfk5EmusKKLjA/PnfmwWsu99k m2+9ywJYIjgt6Os/JKL3hZIRHX5VY1PJ7aZDYA9d+yrH9a5ynykdhfvcsyxBBx9Xnt DzpFVgLualc7xBBQg79mgeWUrPzDijBGcbGRynJWBpWykQp+OuRbob97E20plAKXNh tc58PanetBjxv0VOmi4ESORc0VYSoIdAEjVbRIQ7BODuz5kWegYZMdigULdGkDoaI1 Em3p50fyTmVgA== From: Kalle Valo To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Gregory Greenman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 05/13] tracing/iwlwifi: Use the new __vstring() helper References: <20220705224453.120955146@goodmis.org> <20220705224749.806599472@goodmis.org> Date: Fri, 08 Jul 2022 08:03:11 +0300 In-Reply-To: <20220705224749.806599472@goodmis.org> (Steven Rostedt's message of "Tue, 05 Jul 2022 18:44:58 -0400") Message-ID: <87ilo8tcvk.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Steven Rostedt writes: > From: "Steven Rostedt (Google)" > > Instead of open coding a __dynamic_array() with a fixed length (which > defeats the purpose of the dynamic array in the first place). Use the new > __vstring() helper that will use a va_list and only write enough of the > string into the ring buffer that is needed. > > Cc: Gregory Greenman > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Steven Rostedt (Google) > --- > .../net/wireless/intel/iwlwifi/iwl-devtrace-msg.h | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) Feel free to take this via your tree: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches