netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kurt Kanzenbach <kurt@linutronix.de>
To: Richard Cochran <richardcochran@gmail.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Po Liu <po.liu@nxp.com>, "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Antoine Tenart <atenart@kernel.org>,
	"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
	"Y.B. Lu" <yangbo.lu@nxp.com>, Rui Sousa <rui.sousa@nxp.com>,
	"Allan W . Nielsen" <allan.nielsen@microchip.com>
Subject: Re: [PATCH net-next 4/4] net: mscc: ocelot: set up traps for PTP packets
Date: Fri, 03 Dec 2021 09:27:22 +0100	[thread overview]
Message-ID: <87ilw66ql1.fsf@kurt> (raw)
In-Reply-To: <20211126170801.GF27081@hoboy.vegasvil.org>

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

Hi Richard,

On Fri Nov 26 2021, Richard Cochran wrote:
> On Fri, Nov 26, 2021 at 05:01:13PM +0000, Vladimir Oltean wrote:
>
>> This, to me, sounds more like the bridge trapping the packets on br0
>> instead of letting them flow on the port netdevices, which is solved by
>> some netfilter rules? Or is it really a driver/hardware issue?
>> 
>> https://lore.kernel.org/netdev/20211116102138.26vkpeh23el6akya@skbuf/
>
> Yeah, thanks for the link.  I had seen it, but alas it came too late
> for me to try on actual working HW.  Maybe it fixes the issue.
>
> If someone out there has a Marvell switch, please try it and let us
> know...

I did some testing on a Marvell Topaz switch (mv88e6341). The Boundary
Clock over UDPv4/UDPv6 using Vladimir's netfilter rules doesn't
work. Even though I've successfully tested these rules on TI CPSW
(switchdev variant) and hellcreek.

However, BC over Layer 2 transport is also not really working well, as
the switch forwards PTP packets (instead of trapping?). Furthermore,
ptp4l reports loosing of timestamps when running on multiple switch
ports.

Tested with Linux v5.16.

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  parent reply	other threads:[~2021-12-03  8:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25 23:21 [PATCH net-next 0/4] Fix broken PTP over IP on Ocelot switches Vladimir Oltean
2021-11-25 23:21 ` [PATCH net-next 1/4] net: mscc: ocelot: don't downgrade timestamping RX filters in SIOCSHWTSTAMP Vladimir Oltean
2021-11-25 23:21 ` [PATCH net-next 2/4] net: mscc: ocelot: create a function that replaces an existing VCAP filter Vladimir Oltean
2021-11-25 23:21 ` [PATCH net-next 3/4] net: ptp: add a definition for the UDP port for IEEE 1588 general messages Vladimir Oltean
2021-11-25 23:21 ` [PATCH net-next 4/4] net: mscc: ocelot: set up traps for PTP packets Vladimir Oltean
2021-11-26 16:58   ` Richard Cochran
2021-11-26 17:01     ` Vladimir Oltean
2021-11-26 17:08       ` Richard Cochran
2021-11-26 17:11         ` Vladimir Oltean
2021-12-03  8:27         ` Kurt Kanzenbach [this message]
2021-11-25 23:45 ` [PATCH net-next 0/4] Fix broken PTP over IP on Ocelot switches Vladimir Oltean
2021-11-26  3:01   ` Jakub Kicinski
2021-11-26  9:55     ` Vladimir Oltean
2021-11-26 18:35       ` Jakub Kicinski
2021-11-26 19:38         ` Vladimir Oltean
2021-11-26 19:55           ` Jakub Kicinski
2021-11-26 16:44 ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilw66ql1.fsf@kurt \
    --to=kurt@linutronix.de \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=allan.nielsen@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=atenart@kernel.org \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=po.liu@nxp.com \
    --cc=richardcochran@gmail.com \
    --cc=rui.sousa@nxp.com \
    --cc=vivien.didelot@gmail.com \
    --cc=vladimir.oltean@nxp.com \
    --cc=xiaoliang.yang_1@nxp.com \
    --cc=yangbo.lu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).