From: Petr Machata <petrm@mellanox.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"roopa@cumulusnetworks.com" <roopa@cumulusnetworks.com>,
"jakub.kicinski@netronome.com" <jakub.kicinski@netronome.com>,
"mrv@mojatatu.com" <mrv@mojatatu.com>,
Ido Schimmel <idosch@mellanox.com>,
"jiri@resnulli.us" <jiri@resnulli.us>
Subject: Re: [PATCH net-next mlxsw v1 00/10] Add a new Qdisc, ETS
Date: Wed, 18 Dec 2019 09:04:30 +0000 [thread overview]
Message-ID: <87immengwz.fsf@mellanox.com> (raw)
In-Reply-To: <20191217.213823.770260276225386300.davem@davemloft.net>
David Miller <davem@davemloft.net> writes:
> From: Petr Machata <petrm@mellanox.com>
> Date: Mon, 16 Dec 2019 17:01:36 +0000
>
>> The IEEE standard 802.1Qaz (and 802.1Q-2014) specifies four principal
>> transmission selection algorithms: strict priority, credit-based shaper,
>> ETS (bandwidth sharing), and vendor-specific. All these have their
>> corresponding knobs in DCB. But DCB does not have interfaces to configure
>> RED and ECN, unlike Qdiscs.
> ...
>
> I have no problem with this new schedule or how it is coded.
>
> But I really want there to be some documentation blurb in the Kconfig
> entry (less verbose) and in a code comment of the scheduler itself
> (more verbose) which explains where this is derived from.
>
> People can indeed look at the commit but I think if someone just sees
> the new Kconfig or looks at the code they should be able to read
> something there that says what this thing is.
>
> The commit log message for patch #4 would be good to use as a basis.
>
> Thank you.
OK, I'll spin a v2.
prev parent reply other threads:[~2019-12-18 9:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 17:01 [PATCH net-next mlxsw v1 00/10] Add a new Qdisc, ETS Petr Machata
2019-12-16 17:01 ` [PATCH net-next mlxsw v1 01/10] net: pkt_cls: Clarify a comment Petr Machata
2019-12-16 17:01 ` [PATCH net-next mlxsw v1 02/10] mlxsw: spectrum_qdisc: " Petr Machata
2019-12-16 17:01 ` [PATCH net-next mlxsw v1 03/10] mlxsw: spectrum: Rename MLXSW_REG_QEEC_HIERARCY_* enumerators Petr Machata
2019-12-16 17:01 ` [PATCH net-next mlxsw v1 04/10] net: sch_ets: Add a new Qdisc Petr Machata
2019-12-16 17:01 ` [PATCH net-next mlxsw v1 05/10] net: sch_ets: Make the ETS qdisc offloadable Petr Machata
2019-12-16 17:01 ` [PATCH net-next mlxsw v1 06/10] mlxsw: spectrum_qdisc: Generalize PRIO offload to support ETS Petr Machata
2019-12-16 17:01 ` [PATCH net-next mlxsw v1 07/10] mlxsw: spectrum_qdisc: Support offloading of ETS Qdisc Petr Machata
2019-12-16 17:01 ` [PATCH net-next mlxsw v1 08/10] selftests: forwarding: Move start_/stop_traffic from mlxsw to lib.sh Petr Machata
2019-12-16 17:01 ` [PATCH net-next mlxsw v1 09/10] selftests: forwarding: sch_ets: Add test coverage for ETS Qdisc Petr Machata
2019-12-16 17:01 ` [PATCH net-next mlxsw v1 10/10] selftests: qdiscs: " Petr Machata
2019-12-18 5:38 ` [PATCH net-next mlxsw v1 00/10] Add a new Qdisc, ETS David Miller
2019-12-18 9:04 ` Petr Machata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87immengwz.fsf@mellanox.com \
--to=petrm@mellanox.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).