From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47F1AC282C0 for ; Wed, 23 Jan 2019 14:29:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E98B2184D for ; Wed, 23 Jan 2019 14:29:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="uwVM3u+m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726313AbfAWO3i (ORCPT ); Wed, 23 Jan 2019 09:29:38 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:41481 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726183AbfAWO3h (ORCPT ); Wed, 23 Jan 2019 09:29:37 -0500 Received: by mail-wr1-f66.google.com with SMTP id x10so2685983wrs.8 for ; Wed, 23 Jan 2019 06:29:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=K2fVsRZyRwB3XQoA+Z/A5LALLUnlnjBmP9FWq5mrGc0=; b=uwVM3u+mWsQXvhIvnUW8+Sd2cAofTaQtdqRFLoZ6Y4WOuhFy6ogszh1czCqvPHHecr 8Zz5yUf6r7WxtoDc11qCj+n8d2by4h0P6h7IjjMPyCkHvKK2Gh+cdnzVqttW4VjgoVky XCK/4SMffDPsSUME3THEz+6J5PvxfMLYn6NiX5Gtc+r92haE8nj4p4wi7P3mRpNJrTGm hxjH057CgUKnnPsMJdYnQ5ixmEB2W8zOJDMUheUw1OvXNxrY9xRamGXsjAxjhoQ9eqrt oQTX94d4iFvlWDd0X/QAN/Ek4F4/sltGXIkGKpCkkzwizQYI7E3whMoAryD0JUcqaAAT Wjzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=K2fVsRZyRwB3XQoA+Z/A5LALLUnlnjBmP9FWq5mrGc0=; b=Hu9FkKudRfDx/I8bjOH99x/6tq6NHJsIqL5GBR58xFOWF7oxlDhv64jTwiwpCIUxzx ofHW2yc4MdhLcAf8uoIsHf2OrEyriRAZw6efenpBbLXG0JKehDunvL3iLBc7xy7lWu9q tAg+A5mVflxwE+YaYdnJc4di+ByXkPvas+bWjIlKq20qK6s+Bous1YIMfE4qNqiyZrSB AiJsEvY6PrKGdg0hlEAE5ESxCXe13Ohpg9S1IwaQBzKQBV/kH7wQzaxvXVRfkXFp548F +QiDoixA/J/xndH9PatWGEu6mILKrrze8KTx+hlZacv8W1olmNSzSfiEF6ud7jYFsEN7 p8hQ== X-Gm-Message-State: AJcUukdpoluc9C94e/KxbDu9YD9EINBhE/slKcDg4qChD7RYobOpfJzy TZwqpqnE+EfKAK0+GP/7d9ihdA== X-Google-Smtp-Source: ALg8bN4qFTqtf5t9agqTcrgF8fmf3Vifha5QiJ3uhe2l1sNmx5xIahHvFo1UKYx+Er7dUhvo8Ip9FQ== X-Received: by 2002:adf:9521:: with SMTP id 30mr2897055wrs.192.1548253775953; Wed, 23 Jan 2019 06:29:35 -0800 (PST) Received: from LAPTOP-V3S7NLPL ([217.38.71.146]) by smtp.gmail.com with ESMTPSA id 202sm69203952wmt.8.2019.01.23.06.29.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Jan 2019 06:29:34 -0800 (PST) References: <1548076553-31268-1-git-send-email-jiong.wang@netronome.com> <1548076553-31268-9-git-send-email-jiong.wang@netronome.com> User-agent: mu4e 0.9.18; emacs 25.2.2 From: Jiong Wang To: Jiong Wang Cc: ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH bpf-next v2 08/16] bpf: functional and min/max reasoning unit tests for JMP32 In-reply-to: <1548076553-31268-9-git-send-email-jiong.wang@netronome.com> Date: Wed, 23 Jan 2019 14:29:33 +0000 Message-ID: <87imyfa1ma.fsf@netronome.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jiong Wang writes: > +/* BPF_RAND_SEXT_R7 contains 5 instructions, it initializes R7 into a random > + * negative u32, and sign-extend it into 64-bit. > + */ > +#define BPF_RAND_SEXT_R7 \ > + BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, \ > + BPF_FUNC_get_prandom_u32), \ > + BPF_MOV64_REG(BPF_REG_7, BPF_REG_0), \ > + BPF_ALU64_IMM(BPF_OR, BPF_REG_7, 0x80000000) \ ^~~~ ',' missing > + BPF_ALU64_IMM(BPF_LSH, BPF_REG_7, 32), \ > + BPF_ALU64_IMM(BPF_ARSH, BPF_REG_7, 32), ^~~~ ',' should be removed Apology, just found there is a minor fix on testcase that I forget to commit before generating patch set. One ',' is missing and one ',' should be removed as described above. I will correct this in v3 together with other reviews if any. Regards, Jiong