From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH AUTOSEL 4.14 01/41] mac80211_hwsim: fix module init error paths for netlink Date: Thu, 13 Dec 2018 11:15:27 +0200 Message-ID: <87imzx949c.fsf@purkki.adurom.net> References: <20181213043054.75891-1-sashal@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Alexey Khoroshilov , Johannes Berg , linux-wireless@vger.kernel.org, netdev@vger.kernel.org To: Sasha Levin Return-path: In-Reply-To: <20181213043054.75891-1-sashal@kernel.org> (Sasha Levin's message of "Wed, 12 Dec 2018 23:30:14 -0500") Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Sasha Levin writes: > From: Alexey Khoroshilov > > [ Upstream commit 05cc09de4c017663a217630682041066f2f9a5cd ] > > There is no unregister netlink notifier and family on error paths > in init_mac80211_hwsim(). Also there is an error path where > hwsim_class is not destroyed. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov > Fixes: 62759361eb49 ("mac80211-hwsim: Provide multicast event for HWSIM_CMD_NEW_RADIO") > Signed-off-by: Johannes Berg > Signed-off-by: Sasha Levin BTW, thanks for adding "X-Patchwork-Hint: Ignore" to the headers. I don't see this patch in patchwork and that helps me a lot :) -- Kalle Valo