From mboxrd@z Thu Jan 1 00:00:00 1970 From: Atzm Watanabe Subject: Re: [PATCH iproute2 v2] vxlan: Allow setting destination to unicast address. Date: Fri, 12 Apr 2013 14:31:34 +0900 Message-ID: <87ip3smi15.wl%atzm@stratosphere.co.jp> References: <87li8pmkvh.wl%atzm@stratosphere.co.jp> <1365702500.7355.0.camel@bwh-desktop.uk.solarflarecom.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: , Stephen Hemminger To: Ben Hutchings Return-path: Received: from mail-pa0-f52.google.com ([209.85.220.52]:48293 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752541Ab3DLFaz (ORCPT ); Fri, 12 Apr 2013 01:30:55 -0400 Received: by mail-pa0-f52.google.com with SMTP id fb10so1272412pad.25 for ; Thu, 11 Apr 2013 22:30:55 -0700 (PDT) In-Reply-To: <1365702500.7355.0.camel@bwh-desktop.uk.solarflarecom.com> Sender: netdev-owner@vger.kernel.org List-ID: At Thu, 11 Apr 2013 18:48:20 +0100, Ben Hutchings wrote: > > On Thu, 2013-04-11 at 19:17 +0900, Atzm Watanabe wrote: > > This patch allows setting VXLAN destination to unicast address. > > It allows that VXLAN can be used as peer-to-peer tunnel without > > multicast. > > > > v2: use a new argument "remote" instead of "group" based by > > Stephen Hemminger's comments. > > > > Signed-off-by: Atzm Watanabe > [...] > > --- a/ip/iplink_vxlan.c > > +++ b/ip/iplink_vxlan.c > > @@ -23,7 +23,8 @@ > > > > static void explain(void) > > { > > - fprintf(stderr, "Usage: ... vxlan id VNI [ group ADDR ] [ local ADDR ]\n"); > > + fprintf(stderr, "Usage: ... vxlan id VNI [ group ADDR ] [ remote ADDR ]\n"); > [...] > > Shouldn't that be "[ group|remote ADDR ]", to show that you can specify > one or the other? Yes, basically I agreed. I think this should be "[ { group | remote } ADDR ]", to accommodate the notation to others. I'll fix this and resend the patch. Thanks.