netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Arjan van de Ven <arjan@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Yinghai Lu <yinghai@kernel.org>,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, netdev@vger.kernel.org,
	x86@kernel.org
Subject: Re: kerneloops.org report for the week
Date: Mon, 29 Jun 2009 11:05:03 +0200	[thread overview]
Message-ID: <87iqifl8ao.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20090629031804.GA6764@elte.hu> (Ingo Molnar's message of "Mon, 29 Jun 2009 05:18:04 +0200")

Ingo Molnar <mingo@elte.hu> writes:
>
>> Rank 8: generic_get_mtrr (warning)
>> 	Reported 544 times (2061 total reports)
>> 	BIOS bug where the MTRRs are not set up correctly
>> 	This warning was last seen in version 2.6.30, and first seen in 2.6.25.3.
>> 	More info: http://www.kerneloops.org/searchweek.php?search=generic_get_mtrr
>
> I think this calls for enabling the x86 MTRR sanitizer by default - 
> 500 out of 15000 reports suggests a significant proportion of Linux 
> systems is affected by MTRR setup problems.

The question is if the MTRRs are really wrong. The generic.c code checks
against the maximum address space reported by the CPU, but the BIOS might
only sets up the address space that is actually used. The later
is not really wrong; it's not needed to set MTRRs for non existing
mappings.

It might be better to double check against the max e820 mapping too
or drop that check.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

      reply	other threads:[~2009-06-29  9:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-28 16:10 kerneloops.org report for the week Arjan van de Ven
2009-06-29  3:18 ` Ingo Molnar
2009-06-29  9:05   ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iqifl8ao.fsf@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).