* [PATCH] net: phy: qt2025: Fix hardware revision check comment
@ 2025-02-17 23:53 Charalampos Mitrodimas
2025-02-19 1:02 ` FUJITA Tomonori
0 siblings, 1 reply; 5+ messages in thread
From: Charalampos Mitrodimas @ 2025-02-17 23:53 UTC (permalink / raw)
To: FUJITA Tomonori, Trevor Gross, Andrew Lunn, Heiner Kallweit,
Russell King, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: netdev, rust-for-linux, linux-kernel
Correct the hardware revision check comment in the QT2025 driver. The
revision value was documented as 0x3b instead of the correct 0xb3,
which matches the actual comparison logic in the code.
Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs
index 1ab065798175b4f54c5f2fd6c871ba2942c48bf1..7e754d5d71544c6d6b6a6d90416a5a130ba76108 100644
--- a/drivers/net/phy/qt2025.rs
+++ b/drivers/net/phy/qt2025.rs
@@ -41,7 +41,7 @@ impl Driver for PhyQT2025 {
fn probe(dev: &mut phy::Device) -> Result<()> {
// Check the hardware revision code.
- // Only 0x3b works with this driver and firmware.
+ // Only 0xb3 works with this driver and firmware.
let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?;
if (hw_rev >> 8) != 0xb3 {
return Err(code::ENODEV);
---
base-commit: beeb78d46249cab8b2b8359a2ce8fa5376b5ad2d
change-id: 20250218-qt2025-comment-fix-31a7f8fcbc64
Best regards,
--
Charalampos Mitrodimas <charmitro@posteo.net>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net: phy: qt2025: Fix hardware revision check comment
2025-02-17 23:53 [PATCH] net: phy: qt2025: Fix hardware revision check comment Charalampos Mitrodimas
@ 2025-02-19 1:02 ` FUJITA Tomonori
2025-02-19 13:00 ` Andrew Lunn
2025-02-19 13:14 ` Charalampos Mitrodimas
0 siblings, 2 replies; 5+ messages in thread
From: FUJITA Tomonori @ 2025-02-19 1:02 UTC (permalink / raw)
To: charmitro
Cc: fujita.tomonori, tmgross, andrew, hkallweit1, linux, davem,
edumazet, kuba, pabeni, netdev, rust-for-linux, linux-kernel
On Mon, 17 Feb 2025 23:53:50 +0000
Charalampos Mitrodimas <charmitro@posteo.net> wrote:
> Correct the hardware revision check comment in the QT2025 driver. The
> revision value was documented as 0x3b instead of the correct 0xb3,
> which matches the actual comparison logic in the code.
>
> Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net>
> ---
> drivers/net/phy/qt2025.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs
> index 1ab065798175b4f54c5f2fd6c871ba2942c48bf1..7e754d5d71544c6d6b6a6d90416a5a130ba76108 100644
> --- a/drivers/net/phy/qt2025.rs
> +++ b/drivers/net/phy/qt2025.rs
> @@ -41,7 +41,7 @@ impl Driver for PhyQT2025 {
>
> fn probe(dev: &mut phy::Device) -> Result<()> {
> // Check the hardware revision code.
> - // Only 0x3b works with this driver and firmware.
> + // Only 0xb3 works with this driver and firmware.
> let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?;
> if (hw_rev >> 8) != 0xb3 {
> return Err(code::ENODEV);
Oops,
Reviewed-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
Given that this patch is expected to be merged via netdev, you might
need to resend with a proper subject:
https://elixir.bootlin.com/linux/v6.13/source/Documentation/process/maintainer-netdev.rst
Thanks,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: phy: qt2025: Fix hardware revision check comment
2025-02-19 1:02 ` FUJITA Tomonori
@ 2025-02-19 13:00 ` Andrew Lunn
2025-02-19 13:08 ` Charalampos Mitrodimas
2025-02-19 13:14 ` Charalampos Mitrodimas
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Lunn @ 2025-02-19 13:00 UTC (permalink / raw)
To: FUJITA Tomonori
Cc: charmitro, tmgross, hkallweit1, linux, davem, edumazet, kuba,
pabeni, netdev, rust-for-linux, linux-kernel
On Wed, Feb 19, 2025 at 10:02:00AM +0900, FUJITA Tomonori wrote:
> On Mon, 17 Feb 2025 23:53:50 +0000
> Charalampos Mitrodimas <charmitro@posteo.net> wrote:
>
> > Correct the hardware revision check comment in the QT2025 driver. The
> > revision value was documented as 0x3b instead of the correct 0xb3,
> > which matches the actual comparison logic in the code.
> >
> > Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net>
> > ---
> > drivers/net/phy/qt2025.rs | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs
> > index 1ab065798175b4f54c5f2fd6c871ba2942c48bf1..7e754d5d71544c6d6b6a6d90416a5a130ba76108 100644
> > --- a/drivers/net/phy/qt2025.rs
> > +++ b/drivers/net/phy/qt2025.rs
> > @@ -41,7 +41,7 @@ impl Driver for PhyQT2025 {
> >
> > fn probe(dev: &mut phy::Device) -> Result<()> {
> > // Check the hardware revision code.
> > - // Only 0x3b works with this driver and firmware.
> > + // Only 0xb3 works with this driver and firmware.
> > let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?;
> > if (hw_rev >> 8) != 0xb3 {
> > return Err(code::ENODEV);
>
> Oops,
>
> Reviewed-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
>
> Given that this patch is expected to be merged via netdev, you might
> need to resend with a proper subject:
>
> https://elixir.bootlin.com/linux/v6.13/source/Documentation/process/maintainer-netdev.rst
Please also include a Fixes: tag.
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: phy: qt2025: Fix hardware revision check comment
2025-02-19 13:00 ` Andrew Lunn
@ 2025-02-19 13:08 ` Charalampos Mitrodimas
0 siblings, 0 replies; 5+ messages in thread
From: Charalampos Mitrodimas @ 2025-02-19 13:08 UTC (permalink / raw)
To: Andrew Lunn
Cc: FUJITA Tomonori, tmgross, hkallweit1, linux, davem, edumazet,
kuba, pabeni, netdev, rust-for-linux, linux-kernel
Andrew Lunn <andrew@lunn.ch> writes:
> On Wed, Feb 19, 2025 at 10:02:00AM +0900, FUJITA Tomonori wrote:
>> On Mon, 17 Feb 2025 23:53:50 +0000
>> Charalampos Mitrodimas <charmitro@posteo.net> wrote:
>>
>> > Correct the hardware revision check comment in the QT2025 driver. The
>> > revision value was documented as 0x3b instead of the correct 0xb3,
>> > which matches the actual comparison logic in the code.
>> >
>> > Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net>
>> > ---
>> > drivers/net/phy/qt2025.rs | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs
>> > index 1ab065798175b4f54c5f2fd6c871ba2942c48bf1..7e754d5d71544c6d6b6a6d90416a5a130ba76108 100644
>> > --- a/drivers/net/phy/qt2025.rs
>> > +++ b/drivers/net/phy/qt2025.rs
>> > @@ -41,7 +41,7 @@ impl Driver for PhyQT2025 {
>> >
>> > fn probe(dev: &mut phy::Device) -> Result<()> {
>> > // Check the hardware revision code.
>> > - // Only 0x3b works with this driver and firmware.
>> > + // Only 0xb3 works with this driver and firmware.
>> > let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?;
>> > if (hw_rev >> 8) != 0xb3 {
>> > return Err(code::ENODEV);
>>
>> Oops,
>>
>> Reviewed-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
>>
>> Given that this patch is expected to be merged via netdev, you might
>> need to resend with a proper subject:
>>
>> https://elixir.bootlin.com/linux/v6.13/source/Documentation/process/maintainer-netdev.rst
>
> Please also include a Fixes: tag.
>
> Andrew
Hi Andrew,
Included it, as the documentation states.
A v2 patch is up[1].
C. Mitrodimas
[1]: https://lore.kernel.org/rust-for-linux/20250219-qt2025-comment-fix-v2-1-029f67696516@posteo.net
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: phy: qt2025: Fix hardware revision check comment
2025-02-19 1:02 ` FUJITA Tomonori
2025-02-19 13:00 ` Andrew Lunn
@ 2025-02-19 13:14 ` Charalampos Mitrodimas
1 sibling, 0 replies; 5+ messages in thread
From: Charalampos Mitrodimas @ 2025-02-19 13:14 UTC (permalink / raw)
To: FUJITA Tomonori
Cc: tmgross, andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni,
netdev, rust-for-linux, linux-kernel
FUJITA Tomonori <fujita.tomonori@gmail.com> writes:
> On Mon, 17 Feb 2025 23:53:50 +0000
> Charalampos Mitrodimas <charmitro@posteo.net> wrote:
>
>> Correct the hardware revision check comment in the QT2025 driver. The
>> revision value was documented as 0x3b instead of the correct 0xb3,
>> which matches the actual comparison logic in the code.
>>
>> Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net>
>> ---
>> drivers/net/phy/qt2025.rs | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs
>> index 1ab065798175b4f54c5f2fd6c871ba2942c48bf1..7e754d5d71544c6d6b6a6d90416a5a130ba76108 100644
>> --- a/drivers/net/phy/qt2025.rs
>> +++ b/drivers/net/phy/qt2025.rs
>> @@ -41,7 +41,7 @@ impl Driver for PhyQT2025 {
>>
>> fn probe(dev: &mut phy::Device) -> Result<()> {
>> // Check the hardware revision code.
>> - // Only 0x3b works with this driver and firmware.
>> + // Only 0xb3 works with this driver and firmware.
>> let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?;
>> if (hw_rev >> 8) != 0xb3 {
>> return Err(code::ENODEV);
>
> Oops,
>
> Reviewed-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
>
> Given that this patch is expected to be merged via netdev, you might
> need to resend with a proper subject:
>
> https://elixir.bootlin.com/linux/v6.13/source/Documentation/process/maintainer-netdev.rst
Hi Fujita,
Very helpful; didn't think to check the Networking subsystem workflow
docs.
Thanks,
C. Mitrodimas
>
> Thanks,
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-19 13:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-17 23:53 [PATCH] net: phy: qt2025: Fix hardware revision check comment Charalampos Mitrodimas
2025-02-19 1:02 ` FUJITA Tomonori
2025-02-19 13:00 ` Andrew Lunn
2025-02-19 13:08 ` Charalampos Mitrodimas
2025-02-19 13:14 ` Charalampos Mitrodimas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).