From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B07622AD00 for ; Wed, 19 Feb 2025 13:08:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739970502; cv=none; b=uPQczc++bH5EMcmJrlETCpQlQbaXV6b/3ymeD5G+XjKML77UGG4iHUmxAWA3WtSGOdYNPxpMgok02/YG+m81v1qlSN0EkeuTD01mlwaLr6oRh+njm8nExyBxp4Ve6DSTTasB6JV8vs67/ajQ6SgRw+HZxhz4dyR3gca8uu/brxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739970502; c=relaxed/simple; bh=MUhvxhHnTvoE+duYjJ7YbfPA0nuYQDtOLydS3RR3bNA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=di2Ua+RBCZqm2YCyYiB0qetgcuA+5fZjIr2B3NoqTf5tNgKhPd4XdAzFDozLBUvwvu3XGy6JjfwaO+m9DnQuIr/E0PxM8ZSzFsfuPVL3BagYyyaxYiEqSqtnT7ZiQJ1r0roJQg/R8C5dTSB+eQ4zbzZYA6F9Zdi3XslL4APBhDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.net; spf=pass smtp.mailfrom=posteo.net; dkim=pass (2048-bit key) header.d=posteo.net header.i=@posteo.net header.b=UH9i82fT; arc=none smtp.client-ip=185.67.36.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.net header.i=@posteo.net header.b="UH9i82fT" Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 00955240028 for ; Wed, 19 Feb 2025 14:08:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1739970499; bh=MUhvxhHnTvoE+duYjJ7YbfPA0nuYQDtOLydS3RR3bNA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=UH9i82fTg1h7w7390ECacBPovUQoE8P/G5GNVXYseGnWGCVDOfKQ5PyhulAe9YWgM oyTMO0GRgM+BGAb1yk2PX8U0Jez7tWa3rWWsM3L0wN7OiFtRvw8Z86NXQQc00rW0a2 bGN9zqUxK+CRxw41x+UPWFS66pL0+d1Bmi0LqYqu41Tltg7EoGEoWN7cUYhyiMIcBi IRGjwKoOVVWBHDLTjvUrytTcrYIVeMYvlhWOcFQgLEEolpENntmiIchN+J48caOyVV anSpO8RUVC/wueOuEqucDUR/JBUQjagjTyrWKotNUIQS6c5YyhA244D7EfF8rJKH+J WyT0bq9Dz/AqA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YycC36ZPlz9rxQ; Wed, 19 Feb 2025 14:08:15 +0100 (CET) From: Charalampos Mitrodimas To: Andrew Lunn Cc: FUJITA Tomonori , tmgross@umich.edu, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: phy: qt2025: Fix hardware revision check comment In-Reply-To: References: <20250218-qt2025-comment-fix-v1-1-743e87c0040c@posteo.net> <20250219.100200.440798533601878204.fujita.tomonori@gmail.com> Date: Wed, 19 Feb 2025 13:08:07 +0000 Message-ID: <87jz9m13rc.fsf@posteo.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Andrew Lunn writes: > On Wed, Feb 19, 2025 at 10:02:00AM +0900, FUJITA Tomonori wrote: >> On Mon, 17 Feb 2025 23:53:50 +0000 >> Charalampos Mitrodimas wrote: >> >> > Correct the hardware revision check comment in the QT2025 driver. The >> > revision value was documented as 0x3b instead of the correct 0xb3, >> > which matches the actual comparison logic in the code. >> > >> > Signed-off-by: Charalampos Mitrodimas >> > --- >> > drivers/net/phy/qt2025.rs | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs >> > index 1ab065798175b4f54c5f2fd6c871ba2942c48bf1..7e754d5d71544c6d6b6a6d90416a5a130ba76108 100644 >> > --- a/drivers/net/phy/qt2025.rs >> > +++ b/drivers/net/phy/qt2025.rs >> > @@ -41,7 +41,7 @@ impl Driver for PhyQT2025 { >> > >> > fn probe(dev: &mut phy::Device) -> Result<()> { >> > // Check the hardware revision code. >> > - // Only 0x3b works with this driver and firmware. >> > + // Only 0xb3 works with this driver and firmware. >> > let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?; >> > if (hw_rev >> 8) != 0xb3 { >> > return Err(code::ENODEV); >> >> Oops, >> >> Reviewed-by: FUJITA Tomonori >> >> Given that this patch is expected to be merged via netdev, you might >> need to resend with a proper subject: >> >> https://elixir.bootlin.com/linux/v6.13/source/Documentation/process/maintainer-netdev.rst > > Please also include a Fixes: tag. > > Andrew Hi Andrew, Included it, as the documentation states. A v2 patch is up[1]. C. Mitrodimas [1]: https://lore.kernel.org/rust-for-linux/20250219-qt2025-comment-fix-v2-1-029f67696516@posteo.net