From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54E571FAEEC for ; Thu, 14 Nov 2024 13:13:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731589995; cv=none; b=P3R3sUuqMr6ZO4mQAr12Pc9Blcmra1BW3qduQa0TUYcmHBnSA5aZysIyKLFikjzZIAnmKPTaPHLKtW4sNGv26nNvN3BoLbGyQjna7cJOSWDR8tGExrpgdnsIJD1gmYiZMLusE47BlHQ3QTaMyuTeY0YVRKTbUqe+ZJRa32BChtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731589995; c=relaxed/simple; bh=BMqdEvSo2XGJTRPGsNA6sRZBHIQCF0fBhcmVmqff8lE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=U/ILdPoJsJHYrFz97m/R/uegy+giqAx/3ukifJ628C+oRms6r6h94N70Gmvf5gkhMX2whdZLTTgzWhwB3J7JwbkvlEzbTJD8XMNjEUYhjHofXO0g7CCOYa8ukP5KsT+HeZ9QGF5+SMv9k7oQpdMD0aCWQRyQKmooVR0BzYNVMTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LmwUwzfR; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LmwUwzfR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731589993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BMqdEvSo2XGJTRPGsNA6sRZBHIQCF0fBhcmVmqff8lE=; b=LmwUwzfRjXkY4thwfX73uLhrvejfug+lHfRpXeol7HkNfw60CsFZs71IR4dgjEUfvOAFkb bf4aEn4HEP3R0vuHPB4RZPEyMLUjwWHOBBeRK2EyQMmaVrHYS2sfUb3EVhRBO4xyHS+UYV UzcFz4xhGx3SSlOC4p0lAfHxtuszy60= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-646-W9pU428JPnqWmpGl-7mM2g-1; Thu, 14 Nov 2024 08:13:12 -0500 X-MC-Unique: W9pU428JPnqWmpGl-7mM2g-1 X-Mimecast-MFC-AGG-ID: W9pU428JPnqWmpGl-7mM2g Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a9a1be34c68so55319766b.1 for ; Thu, 14 Nov 2024 05:13:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731589991; x=1732194791; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BMqdEvSo2XGJTRPGsNA6sRZBHIQCF0fBhcmVmqff8lE=; b=QMTx0fLHnlIB9D6l/IARjwiz6VADsOzSexjMCFz0pSfXXo+UrGjyx362i7Ev3j5i53 RQlST1KZ4g/3HAI4bBT0KUy+Dsw8i0wVgqJ0wQsvkI7d8AiROST1VYPmwfzBgMsyjlM9 rjrq5Rk41Di+J/ZY7JNbEJZAOiOvBQBkU4ABodHG6rswcK/ER6Vl1uuLB1gqmfcuoCLY /w1yCv4eZN276nCseVDxfk5VjJQhXjLxRysxdJYdUl0sHGkEaC5gJO9W/kkqSiG/urIZ Avq3TppIaKuj8kBO0xV+c6QDQY96J9MwsLtC+1F4fC5WJMG99V6xtxJVU5Rq18siV/hG wwxw== X-Forwarded-Encrypted: i=1; AJvYcCVdsTZ2e8iPplccWP1xSIwUzSfLhoMjc/wQdUVq/zxH44Q9QmPFlJfOjCSSiSAkp+7ZrllQvJk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8M84bt/qIRPanjoOrOYSwWK6n4ssXSZkA63M6fbASTyzsnBzr si8yftWaMzbJFSjnxuWJjnwFuT0jaJGM62bBXnVvOshZfB8bAHU0V39AFuvxzW5PGplvmgvtfYG gUVBeIyczdGEWXqYh3rwdJV2J65B+hfUp10QO52maV6MOnHA/8BCYqg== X-Received: by 2002:a17:906:da87:b0:a9a:7f87:904b with SMTP id a640c23a62f3a-aa1b10a373amr1064627566b.29.1731589990889; Thu, 14 Nov 2024 05:13:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IEOyxFRsRS28SbNhlIJrT9v3tkoYAXjzIK+RwTYwfJqA2Fz4E6wn0BXG7P2/Dh7o754OHjiSg== X-Received: by 2002:a17:906:da87:b0:a9a:7f87:904b with SMTP id a640c23a62f3a-aa1b10a373amr1064625166b.29.1731589990523; Thu, 14 Nov 2024 05:13:10 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa20dffd742sm63384266b.109.2024.11.14.05.13.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2024 05:13:09 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 6074D164D081; Thu, 14 Nov 2024 14:13:08 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Felix Maurer , bpf@vger.kernel.org Cc: bjorn@kernel.org, magnus.karlsson@intel.com, maciej.fijalkowski@intel.com, jonathan.lemon@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, yoong.siang.song@intel.com, sdf@fomichev.me, netdev@vger.kernel.org, Michal Schmidt Subject: Re: [PATCH bpf] xsk: Free skb when TX metadata options are invalid In-Reply-To: References: X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 14 Nov 2024 14:13:07 +0100 Message-ID: <87jzd6q7q4.fsf@toke.dk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Felix Maurer writes: > When a new skb is allocated for transmitting an xsk descriptor, i.e., for > every non-multibuf descriptor or the first frag of a multibuf descriptor, > but the descriptor is later found to have invalid options set for the TX > metadata, the new skb is never freed. This can leak skbs until the send > buffer is full which makes sending more packets impossible. > > Fix this by freeing the skb in the error path if we are currently dealing > with the first frag, i.e., an skb allocated in this iteration of > xsk_build_skb. > > Fixes: 48eb03dd2630 ("xsk: Add TX timestamp and TX checksum offload suppo= rt") > Reported-by: Michal Schmidt > Signed-off-by: Felix Maurer Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen