From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F6EC13DBB7 for ; Wed, 14 Feb 2024 21:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707947484; cv=none; b=BxXWTh3yDKdxSO+blaMlPjOWPas16ukb+1gTQfNUU/AULcv/2hJd4oBCu4Pxho1tUmRQxDhplbVW0j/3VjUp9YBqvURvpRN3s1oDhTK9WfVcIMvJ986Y2QaLWhKy9rVnDiWtUCW+7qHenLzl8wFOULSZd37TJ7YrMS6f//wiWa8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707947484; c=relaxed/simple; bh=XIUIsuylsJ2s0VEXAcTY/EhCiKZpllNlMEkfCfGawfw=; h=References:From:To:Cc:Subject:Date:In-reply-to:Message-ID: MIME-Version:Content-Type; b=sDeZ062ZAPOa9Em/nh2Uk2DURUgxbxfSG8zMjPAMtz7mp/WBNcG/TpjjiiOaGL2DxyekGwj/NPD8ylXoPJUlLLfAg1UPszBh7CKHkAjMtucuhw5H4mE6PwBNdcRIM2VsVzx3oOJyDb6MHgNpdKuYnb9VLqgesry8d7+R3ezMWaU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=KwJH+yRR; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="KwJH+yRR" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2d1094b549cso2394131fa.3 for ; Wed, 14 Feb 2024 13:51:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1707947477; x=1708552277; darn=vger.kernel.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=nbi5t6r1KEtNuC1fJwyh+eduggjyreAriY+0UM+V9ow=; b=KwJH+yRRogZXsDcuEuw01Dv4s/88injKbXGXTmu6E4o+tJGRL4g4zA1kfIA/h0Nm3E 9sSIqZjo+LyP/jF/dLIl5Cs6c8sOeQo0SwbzIEdbkYTsARmxlDd2gW2kbBJwQrZrYp/h P1IS6xZL3by2xht6eNS0BR/LIOgSJflx60gFnOB/oK2OFtUmhlR/tPk8lMcD5sHA6NOk 0slnOGj7nl/Fb9k29vKvRK0YcZn4BqiOF/23SKTsbu1YX7kjO3aob/pqXd7xw6QyarBi MpZ5IwL1DTFVPRXAEWJsqJCx4JyQX5hqUhdcNPD1VaZPVl+AtorVGCJeRbFO4ozP0gIG bJoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707947477; x=1708552277; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nbi5t6r1KEtNuC1fJwyh+eduggjyreAriY+0UM+V9ow=; b=XsKzGWTqhE65WpzvrteDe0ajzu+8gQxMu7AeCsADfk2f9C+exWy//KpoJHiQpwyPwu PRjWrxLwm8Tjtqp9gS/5SxbzhVckaX5lSSZTZ/umqZ2gAr7cMQpH+Xq7lGPfb0yjXSQa CWBnvj/IOqf6qV7WyzKkPApoR1slrJobF6coxxBuYNuCncJykx+PcW/GuSZ85fBEYv9j 5wfmGw7/2R2oaEq1GWq7FvOWy+/nDtaGrN5ClWG4f41KY0k7ZJQNAMS9sOhKE8DniwyL ZvrEZANMU221k3xKqtXaIzbeYJHVeg3auMF/ibUoLJKjDOVTf3NECLOGC9HtG2nqaCR8 7O5g== X-Forwarded-Encrypted: i=1; AJvYcCWSKIQKNGxjWt3Ei806OV+M02qydiY6coSztBXMc8Q8tfTuDAukD7NSmYByaCdOEYf9eDS+zNP/a6Rgshf2UNLlCfje5E5b X-Gm-Message-State: AOJu0YylUJxPcWctERmlpnTIVwFcppdTAsR9saWdvyNtQRFWe+hZ/Bdn tlx8V0cBGsn5+fXaRBA+/0DscRbEoyTnzTtnrVLQfMyC/I5L9hCNduXJDPmf0MY= X-Google-Smtp-Source: AGHT+IE422E09xZm07yxYe/pkl5wdut9RwVNqm65gSv3mkt8S05D8bGGZevMFlKYib1Nfth/nKoQeA== X-Received: by 2002:a2e:9151:0:b0:2d0:fa5f:af60 with SMTP id q17-20020a2e9151000000b002d0fa5faf60mr2791966ljg.18.1707947477558; Wed, 14 Feb 2024 13:51:17 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVKpu0+yYKrNR2taT0yKq+ixItlSRROEI58uzqY/cLEArTH/LHZYxZsskmoC8vdzmc++GMatmSxkFT3LLpppJB9PeDQFEbZpVautI0ih/Npa/Phl8OoGiQScpoQSTlpV+TCwSvRY9S8xOI+j99n+Amp3hpOraYxRRIYHwGC+Ms= Received: from cloudflare.com ([2a09:bac5:5064:2dc::49:1f2]) by smtp.gmail.com with ESMTPSA id k23-20020a05640212d700b005612987a525sm4949303edx.89.2024.02.14.13.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 13:51:16 -0800 (PST) References: <20240213154416.422739-1-kuba@kernel.org> <20240213154416.422739-4-kuba@kernel.org> <87o7ciltgh.fsf@cloudflare.com> User-agent: mu4e 1.6.10; emacs 29.2 From: Jakub Sitnicki To: Jakub Kicinski Cc: shuah@kernel.org, keescook@chromium.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 3/4] selftests: kselftest_harness: support using xfail Date: Wed, 14 Feb 2024 22:46:46 +0100 In-reply-to: <87o7ciltgh.fsf@cloudflare.com> Message-ID: <87jzn6lnou.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Feb 14, 2024 at 08:40 PM +01, Jakub Sitnicki wrote: [...] > On second thought, if I can suggest a follow up change so this: > > ok 17 # XFAIL SCTP doesn't support IP_BIND_ADDRESS_NO_PORT > > ... becomes this > > ok 17 ip_local_port_range.ip4_stcp.late_bind # XFAIL SCTP doesn't support IP_BIND_ADDRESS_NO_PORT > > You see, we parse test results if they are in TAP format. Lack of test > name for xfail'ed and skip'ed tests makes it difficult to report in CI > which subtest was it. Happy to contribute it, once this series gets > applied. Should have said "harder", not "difficult". That was an overstatement. Test name can be extracted from diagnostic lines preceeding the status. # RUN ip_local_port_range.ip4_stcp.late_bind ... # XFAIL SCTP doesn't support IP_BIND_ADDRESS_NO_PORT # OK ip_local_port_range.ip4_stcp.late_bind ok 17 ip_local_port_range.ip4_stcp.late_bind # XFAIL SCTP doesn't support IP_BIND_ADDRESS_NO_PORT It just makes the TAP parser easier if the test name is included on the status line. That would be the motivation here. Let me know what you think. [...]