From: Kurt Kanzenbach <kurt@linutronix.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: mv88e6xxx: Enable PTP receive for mv88e6390
Date: Thu, 12 Jan 2023 16:21:11 +0100 [thread overview]
Message-ID: <87k01rrd7c.fsf@kurt> (raw)
In-Reply-To: <Y8AGFJlQBEhTqQs7@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
On Thu Jan 12 2023, Andrew Lunn wrote:
> On Thu, Jan 12, 2023 at 10:12:24AM +0100, Kurt Kanzenbach wrote:
>> The switch receives management traffic such as STP and LLDP. However, PTP
>> messages are not received, only transmitted.
>>
>> Ideally, the switch would trap all PTP messages to the management CPU. This
>> particular switch has a PTP block which identifies PTP messages and traps them
>> to a dedicated port. There is a register to program this destination. This is
>> not used at the moment.
>>
>> Therefore, program it to the same port as the MGMT traffic is trapped to. This
>> allows to receive PTP messages as soon as timestamping is enabled.
>>
>> In addition, the datasheet mentions that this register is not valid e.g., for
>> 6190 variants. So, add a new PTP operation which is only added for the both 6390
>> devices.
>
> I assume this also works for the 6290? Please could you also update
> its _ops structure?
According to the datasheet, yes. I'll add this one, too.
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
prev parent reply other threads:[~2023-01-12 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 9:12 [PATCH net-next v2] net: dsa: mv88e6xxx: Enable PTP receive for mv88e6390 Kurt Kanzenbach
2023-01-12 13:07 ` Andrew Lunn
2023-01-12 15:21 ` Kurt Kanzenbach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k01rrd7c.fsf@kurt \
--to=kurt@linutronix.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).