From: Petr Machata <petrm@nvidia.com>
To: Petr Machata <petrm@nvidia.com>
Cc: Daniel Machon <daniel.machon@microchip.com>,
<netdev@vger.kernel.org>, <dsahern@kernel.org>,
<stephen@networkplumber.org>, <maxime.chevallier@bootlin.com>,
<vladimir.oltean@nxp.com>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH iproute2-next 1/2] dcb: add new pcp-prio parameter to dcb app
Date: Thu, 24 Nov 2022 17:53:06 +0100 [thread overview]
Message-ID: <87k03ki8py.fsf@nvidia.com> (raw)
In-Reply-To: <87wn7kibn8.fsf@nvidia.com>
Petr Machata <petrm@nvidia.com> writes:
> This looks good to me overall, I just have a few nits.
Actually, one more fairly fundamental thing that occurred to me. If a
user doesn't care about DEI, they need to do this using two rules: say
1:1 and 1de:1.
I wonder if it would make sense to assume that people are more likely to
not care about DEI at all, and make the 1:1 mean that. Then 1:1 would be
a shorthand for expressing two rules, one for DE=0, one for DE=1.
If the user does care about DEI, they would either say 1de:1 or 1nd:1,
depending on what they want the DEI to be.
If you generally agree with this idea, but don't have spare cycles to
code it up, would you please just make the PCP keys "${prio}de" and
"${prio}nd"? (Or whatever, but have the syntax reflect the DEI state in
both cases.) I think I'll be able to scrape a bit of a free time on some
weekend to add the syntax sugar.
next prev parent reply other threads:[~2022-11-24 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 10:41 [PATCH iproute2-next 0/2] Add pcp-prio and new apptrust subcommand Daniel Machon
2022-11-22 10:41 ` [PATCH iproute2-next 1/2] dcb: add new pcp-prio parameter to dcb app Daniel Machon
2022-11-24 15:30 ` Petr Machata
2022-11-24 16:11 ` Petr Machata
2022-11-24 16:53 ` Petr Machata [this message]
2022-11-25 10:07 ` Daniel.Machon
2022-11-25 13:12 ` Petr Machata
2022-11-22 10:41 ` [PATCH iproute2-next 2/2] dcb: add new subcommand for apptrust Daniel Machon
2022-11-24 16:16 ` Petr Machata
2022-11-25 9:11 ` Daniel.Machon
2022-11-25 13:06 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k03ki8py.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=daniel.machon@microchip.com \
--cc=dsahern@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).