netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kurt Kanzenbach <kurt@linutronix.de>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Jesper Dangaard Brouer <jbrouer@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jesper Dangaard Brouer <brouer@redhat.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	Joanne Koong <joannelkoong@gmail.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Dave Marchevsky <davemarchevsky@fb.com>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	Geliang Tang <geliang.tang@suse.com>,
	Jakub Sitnicki <jakub@cloudflare.com>,
	Network Development <netdev@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: Add BPF-helper for accessing CLOCK_TAI
Date: Thu, 04 Aug 2022 08:40:51 +0200	[thread overview]
Message-ID: <87k07o1pfw.fsf@kurt> (raw)
In-Reply-To: <CAEf4BzZtraeLSP4wcNk7t4sqDK6t2HVoo57nkUhVVLNCWe=JfA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

On Wed Aug 03 2022, Andrii Nakryiko wrote:
>> +void test_tai(void)
>> +{
>> +       struct __sk_buff skb = {
>> +               .tstamp = 0,
>> +               .hwtstamp = 0,
>> +       };
>> +       LIBBPF_OPTS(bpf_test_run_opts, topts,
>> +               .data_in = &pkt_v4,
>> +               .data_size_in = sizeof(pkt_v4),
>> +               .ctx_in = &skb,
>> +               .ctx_size_in = sizeof(skb),
>> +               .ctx_out = &skb,
>> +               .ctx_size_out = sizeof(skb),
>> +       );
>> +       struct timespec now_tai;
>> +       struct bpf_object *obj;
>> +       int ret, prog_fd;
>> +
>> +       ret = bpf_prog_test_load("./test_tai.o",
>> +                                BPF_PROG_TYPE_SCHED_CLS, &obj, &prog_fd);
>
> it would be best to rely on BPF skeleton, please see other tests
> including *.skel.h, thanks
>

Ah, nice. Adjusted the test case accordingly. Will post v2 after the
merge window. Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2022-08-04  6:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06 10:37 [PATCH bpf-next] bpf: Add BPF-helper for accessing CLOCK_TAI Kurt Kanzenbach
2022-06-06 15:57 ` Alexei Starovoitov
2022-06-07  9:14   ` Thomas Gleixner
2022-06-07 19:35     ` Jesper Dangaard Brouer
2022-06-08  2:01       ` Alexei Starovoitov
2022-06-08  6:13         ` Kurt Kanzenbach
2022-08-02  7:06         ` Kurt Kanzenbach
2022-08-02 15:03           ` Alexei Starovoitov
2022-08-03  6:29             ` Kurt Kanzenbach
2022-08-03  9:28               ` Maciej Fijalkowski
2022-08-03 17:29                 ` Andrii Nakryiko
2022-08-03 17:28               ` Andrii Nakryiko
2022-08-04  6:40                 ` Kurt Kanzenbach [this message]
2022-08-09  0:28                   ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k07o1pfw.fsf@kurt \
    --to=kurt@linutronix.de \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=davemarchevsky@fb.com \
    --cc=geliang.tang@suse.com \
    --cc=jakub@cloudflare.com \
    --cc=jbrouer@redhat.com \
    --cc=joannelkoong@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=tglx@linutronix.de \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).