From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Russell King <linux@armlinux.org.uk>,
Ori Shemtov <ori.shemtov@solid-run.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 1/2] arm64: dts: clearfog-gt-8k: fix USB regulator gpio polarity
Date: Fri, 30 Nov 2018 18:45:09 +0100 [thread overview]
Message-ID: <87k1kumpcq.fsf@bootlin.com> (raw)
In-Reply-To: <d02745d924c2ad65cbd1194fc35d12796613722d.1539687053.git.baruch@tkos.co.il> (Baruch Siach's message of "Tue, 16 Oct 2018 13:50:52 +0300")
Hi Baruch,
On mar., oct. 16 2018, Baruch Siach <baruch@tkos.co.il> wrote:
> The fixed regulator driver ignores the gpio flags, so this change has
> no practical effect in the current implementation. Fix it anyway to
> correct the hardware description.
>
Applied on mvebu/dt64
Thanks,
Gregory
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> index aea9c220ae6a..af1310c53bc8 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> @@ -42,7 +42,7 @@
>
> v_5v0_usb3_hst_vbus: regulator-usb3-vbus0 {
> compatible = "regulator-fixed";
> - gpio = <&cp0_gpio2 15 GPIO_ACTIVE_HIGH>;
> + gpio = <&cp0_gpio2 15 GPIO_ACTIVE_LOW>;
> pinctrl-names = "default";
> pinctrl-0 = <&cp0_xhci_vbus_pins>;
> regulator-name = "v_5v0_usb3_hst_vbus";
> --
> 2.19.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
prev parent reply other threads:[~2018-12-01 4:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 10:50 [PATCH 1/2] arm64: dts: clearfog-gt-8k: fix USB regulator gpio polarity Baruch Siach
2018-10-16 10:50 ` [PATCH 2/2] arm64: dts: clearfog-gt-8k: 1G eth PHY reset signal Baruch Siach
2018-11-30 17:45 ` Gregory CLEMENT
2018-11-30 17:45 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1kumpcq.fsf@bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=f.fainelli@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=ori.shemtov@solid-run.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).