From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 1/2] arm64: dts: clearfog-gt-8k: fix USB regulator gpio polarity Date: Fri, 30 Nov 2018 18:45:09 +0100 Message-ID: <87k1kumpcq.fsf@bootlin.com> References: Mime-Version: 1.0 Content-Type: text/plain Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Russell King , Ori Shemtov , Florian Fainelli , netdev@vger.kernel.org, Linus Walleij To: Baruch Siach Return-path: Received: from mail.bootlin.com ([62.4.15.54]:33680 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726650AbeLAEzM (ORCPT ); Fri, 30 Nov 2018 23:55:12 -0500 In-Reply-To: (Baruch Siach's message of "Tue, 16 Oct 2018 13:50:52 +0300") Sender: netdev-owner@vger.kernel.org List-ID: Hi Baruch, On mar., oct. 16 2018, Baruch Siach wrote: > The fixed regulator driver ignores the gpio flags, so this change has > no practical effect in the current implementation. Fix it anyway to > correct the hardware description. > Applied on mvebu/dt64 Thanks, Gregory > Signed-off-by: Baruch Siach > --- > arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts > index aea9c220ae6a..af1310c53bc8 100644 > --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts > +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts > @@ -42,7 +42,7 @@ > > v_5v0_usb3_hst_vbus: regulator-usb3-vbus0 { > compatible = "regulator-fixed"; > - gpio = <&cp0_gpio2 15 GPIO_ACTIVE_HIGH>; > + gpio = <&cp0_gpio2 15 GPIO_ACTIVE_LOW>; > pinctrl-names = "default"; > pinctrl-0 = <&cp0_xhci_vbus_pins>; > regulator-name = "v_5v0_usb3_hst_vbus"; > -- > 2.19.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com