From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vitaly Kuznetsov Subject: RE: [PATCH net-next] hv_netvsc: fix vf serial matching with pci slot info Date: Fri, 12 Oct 2018 08:27:45 +0200 Message-ID: <87k1mnptlq.fsf@vitty.brq.redhat.com> References: <20181011201434.30737-1-haiyangz@linuxonhyperv.com> Mime-Version: 1.0 Content-Type: text/plain Cc: "davem\@davemloft.net" , "netdev\@vger.kernel.org" , KY Srinivasan , Stephen Hemminger , "olaf\@aepfle.de" , "devel\@linuxdriverproject.org" , "linux-kernel\@vger.kernel.org" To: Haiyang Zhang Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Haiyang Zhang writes: >> -----Original Message----- >> From: Haiyang Zhang >> Sent: Thursday, October 11, 2018 4:15 PM >> To: davem@davemloft.net; netdev@vger.kernel.org >> Cc: Haiyang Zhang ; KY Srinivasan >> ; Stephen Hemminger ; >> olaf@aepfle.de; vkuznets ; >> devel@linuxdriverproject.org; linux-kernel@vger.kernel.org >> Subject: [PATCH net-next] hv_netvsc: fix vf serial matching with pci slot info >> >> From: Haiyang Zhang >> >> The VF device's serial number is saved as a string in PCI slot's kobj name, not >> the slot->number. This patch corrects the netvsc driver, so the VF device can be >> successfully paired with synthetic NIC. >> >> Fixes: 00d7ddba1143 ("hv_netvsc: pair VF based on serial number") >> Signed-off-by: Haiyang Zhang > > Thanks Stephen for the reminder -- I added the "reported-by" here: > > Reported-by: Vitaly Kuznetsov Thanks) The difference in the hack I sent to Stephen was that instead of using kstrtou32() and checking the return value I opted for snprintf() and doing strncmp(). -- Vitaly