Re: [PATCH 03/18] rhashtable: remove nulls_base and related code.

Herbert Xu
2018-06-13T06:25:52Z

On Thu, Jun 07, 2018 at 12:49:07PM +1000, NeilBrown wrote:
> On Fri, Jun 01 2018, NeilBrown wrote:
>
> > This "feature" is unused, undocumented, and untested and so
> > doesn't really belong. Next patch will introduce support
> > to detect when a search gets diverted down a different chain,
> > which the common purpose of nulls markers.
> >
> > This patch actually fixes a bug too. The table resizing allows a
> > table to grow to 2^31 buckets, but the hash is truncated to 27 bits -
> > any growth beyond 2^27 is wasteful an ineffective.
> >
> > This patch results in NULLS_MARKER(0) being used for all chains,
> > and leaves the use of rht_is_a_null() to test for it.
> >
> > Signed-off-by: NeilBrown <neilb@suse.com>
>
> Hi Herbert,
> You've acked a few patches that depends on this one, but not this
> patch itself. If you could ack this one, I could submit a collection
> of patches for inclusion (after the merge window closes I guess)
> and then have fewer outstanding.
> This assumes you are in-principle happy with the alternative approach I
> took to handling list-nulls. I got the impression that it was only
> some small details holding that back.

You can add my ack to this patch:

Acked-by: Herbert Xu <herbert@gondor.apana.org.au>

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt