Netdev List
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Kai Heng Feng <kai.heng.feng@canonical.com>
Cc: Felix Fietkau <nbd@nbd.name>,
	ath9k-devel@qca.qualcomm.com, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath9k: turn on btcoex_enable as default
Date: Fri, 09 Feb 2018 09:16:35 +0200	[thread overview]
Message-ID: <87k1vmeip8.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <A5972CE9-8325-404A-A63D-ED29E44FB67B@canonical.com> (Kai Heng Feng's message of "Fri, 9 Feb 2018 12:21:36 +0800")

Kai Heng Feng <kai.heng.feng@canonical.com> writes:

> Hi Felix,
>
>> On Feb 8, 2018, at 7:02 PM, Felix Fietkau <nbd@nbd.name> wrote:
>>
>> On 2018-02-08 06:28, Kai-Heng Feng wrote:
>>> Without btcoex_enable, WiFi activies make both WiFi and Bluetooth
>>> unstable if there's a bluetooth connection.
>>>
>>> Enable this option when bt_ant_diversity is disabled.
>>>
>>> BugLink: https://bugs.launchpad.net/bugs/1746164
>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> I think this might cause regressions on devices that don't have
>> bluetooth. This probably either needs more EEPROM checks, or something
>> to selectively enable it only on affected platforms.
>
> I think it’s better not to use dmi_match. This issue should affect
> more ath9k. And bluetooth peripherals are more than ever now, so it
> would be great to use BT out of the box.

Sure, but we have to make sure that we don't create regressions on
existing systems. For example, did you test this with any system which
don't support btcoex? (just asking, haven't tested this myself)

-- 
Kalle Valo

  reply	other threads:[~2018-02-09  7:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-08  5:28 [PATCH] ath9k: turn on btcoex_enable as default Kai-Heng Feng
2018-02-08 11:02 ` Felix Fietkau
     [not found]   ` <56d650e6-d26f-087c-4e86-2e5d4e859414-Vt+b4OUoWG0@public.gmane.org>
2018-02-09  4:21     ` Kai Heng Feng
2018-02-09  7:16       ` Kalle Valo [this message]
     [not found]         ` <87k1vmeip8.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2018-02-10 13:56           ` Kai Heng Feng
2018-02-10 14:05             ` Felix Fietkau
2018-02-12  4:15               ` Kai Heng Feng
2018-08-23  1:33                 ` Kai-Heng Feng
2018-08-23 11:18                   ` Kalle Valo
2018-08-23 17:06                     ` Tom Psyborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1vmeip8.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath9k-devel@qca.qualcomm.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox