From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Tom Herbert <tom@quantonium.net>
Cc: davem@davemloft.net, netdev@vger.kernel.org, alex.popov@linux.com
Subject: Re: [PATCH net-next 1/2] flow_dissector: Cleanup control flow
Date: Fri, 01 Sep 2017 14:35:59 +0200 [thread overview]
Message-ID: <87k21izjdc.fsf@stressinduktion.org> (raw)
In-Reply-To: <20170831222239.21509-2-tom@quantonium.net> (Tom Herbert's message of "Thu, 31 Aug 2017 15:22:38 -0700")
Tom Herbert <tom@quantonium.net> writes:
> __skb_flow_dissect is riddled with gotos that make discerning the flow,
> debugging, and extending the capability difficult. This patch
> reorganizes things so that we only perform goto's after the two main
> switch statements (no gotos within the cases now). It also eliminates
> several goto labels so that there are only two labels that can be target
> for goto.
The problem with the
fdret = ... ;
break;
is that we now have to count curly braces to look what break does
actually break and where fdret is being processed. With the number of
context lines you send for the patch this is hard to review.
I tend to like the gotos a bit more for now.
[...]
Bye,
Hannes
next prev parent reply other threads:[~2017-09-01 12:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 22:22 [PATCH net-next 0/2] flow_dissector: Flow dissector fixes Tom Herbert
2017-08-31 22:22 ` [PATCH net-next 1/2] flow_dissector: Cleanup control flow Tom Herbert
2017-09-01 12:26 ` Simon Horman
2017-09-01 12:35 ` Hannes Frederic Sowa [this message]
2017-09-01 16:12 ` Tom Herbert
2017-08-31 22:22 ` [PATCH net-next 2/2] flow_dissector: Add limits for encapsulation and EH Tom Herbert
2017-09-01 12:22 ` Simon Horman
2017-09-01 13:32 ` Hannes Frederic Sowa
2017-09-01 15:38 ` Tom Herbert
2017-09-01 16:35 ` Hannes Frederic Sowa
2017-09-01 16:49 ` Tom Herbert
2017-09-01 17:05 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k21izjdc.fsf@stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=alex.popov@linux.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tom@quantonium.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox