From mboxrd@z Thu Jan 1 00:00:00 1970 From: Atzm Watanabe Subject: Re: [PATCH iproute2 v2] vxlan: Allow setting destination to unicast address. Date: Fri, 12 Apr 2013 14:31:32 +0900 Message-ID: <87k3o8mi17.wl%atzm@stratosphere.co.jp> References: <87li8pmkvh.wl%atzm@stratosphere.co.jp> <20130411082438.7fe3421b@nehalam.linuxnetplumber.net> <20130411.133014.1750297317239802950.davem@davemloft.net> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: stephen@networkplumber.org, netdev@vger.kernel.org To: David Miller Return-path: Received: from mail-da0-f47.google.com ([209.85.210.47]:54633 "EHLO mail-da0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752150Ab3DLFaw (ORCPT ); Fri, 12 Apr 2013 01:30:52 -0400 Received: by mail-da0-f47.google.com with SMTP id s35so983620dak.6 for ; Thu, 11 Apr 2013 22:30:51 -0700 (PDT) In-Reply-To: <20130411.133014.1750297317239802950.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: At Thu, 11 Apr 2013 13:30:14 -0400 (EDT), David Miller wrote: > > From: Stephen Hemminger > Date: Thu, 11 Apr 2013 08:24:38 -0700 > > > On Thu, 11 Apr 2013 19:17:54 +0900 > > Atzm Watanabe wrote: > > > >> diff --git a/include/linux/if_link.h b/include/linux/if_link.h > >> index 40167af..0bf03dc 100644 > >> --- a/include/linux/if_link.h > >> +++ b/include/linux/if_link.h > >> @@ -296,6 +296,7 @@ enum { > >> IFLA_VXLAN_GROUP, > >> IFLA_VXLAN_LINK, > >> IFLA_VXLAN_LOCAL, > >> + IFLA_VXLAN_REMOTE, > >> IFLA_VXLAN_TTL, > >> IFLA_VXLAN_TOS, > > > > You can't insert another value into the middle of an enum list. > > It changes the kernel-userspace ABI values. > > Right. Thank you for pointing it out. I'll move IFLA_VXLAN_REMOTE to the last and resend the patch. Thanks.