From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7458830D3E7; Thu, 4 Jun 2026 23:38:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780616303; cv=none; b=rzDZyOFx4zhQ+GzSAq+vUDh1hK9KOhlIH+wCc3lenJMZ/cW5mOf8wlacHHyZEHsVZy3Rfus8yceVBBm5EKkVI4jx4GJz1K7NJ6SkPQCTw/gdiM7eDIJx0ZB0zVQ6XWBnIbscvgwVhSZfQjncxH3uakyVaRQNge0XLWX9Whbzuuo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780616303; c=relaxed/simple; bh=AIQIr0ForNnFUac72qlS61qyI7V+ThigyEDuZnZVggc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=YKYYwWs81HR/L5BwwmUiJFnoJPwvyOlisBsW3UrRpbO3kZWSRI8Bz4EbxFB9wQExTa5+txsUEejujA67yLJuvjLFJkghIEHEpZv1cT8jcnXJNbxuUVzPGwuCiP9r58xCOsF0NN5JOVPTnkPuxDOL8aJepwwXBnwuhTh76bK8DLI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MLkgRTsA; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MLkgRTsA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780616303; x=1812152303; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=AIQIr0ForNnFUac72qlS61qyI7V+ThigyEDuZnZVggc=; b=MLkgRTsA4wqeNG3CFvCPsm90I7v99kMmSUnnDm3bAQR/54SIkf5HNhGQ caWXiQgaIiLPet3khnX9YqWl4Hv48hFG9Kyy0lU1NuVwnOcFYd/kRwMH3 C/XTqWtBZLJxCvK467Hf3HqUKkEZ6GrOHr+RJiprQbINyTDNmrRd0UTTy ObpCYXaF7MDcNTodRRglKU9+aXD0hXy6W9moLq/qnw3hxDoy26ERrYWF7 llTPDYfgwh79vjQv/jUY1FnAYsYPB2K68YXkIaCdpkxkXzfZwNE4GV+NQ guy1ZH4q/7ipFIXLmO3BSh8zLyJh9E2fJIg1vVJwdT34h/QgozGEwki+t g==; X-CSE-ConnectionGUID: OkCK6wYBTdSAW22TxnE8Lg== X-CSE-MsgGUID: LqQDiDQoREe7nW6WcsuI4Q== X-IronPort-AV: E=McAfee;i="6800,10657,11807"; a="85075913" X-IronPort-AV: E=Sophos;i="6.24,188,1774335600"; d="scan'208";a="85075913" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2026 16:38:20 -0700 X-CSE-ConnectionGUID: 8i1oTar4QXezo2FSoxBVCQ== X-CSE-MsgGUID: LcsHNHCoTGCVhaZdDEqLlA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,188,1774335600"; d="scan'208";a="244744337" Received: from vcostago-desk1.jf.intel.com (HELO vcostago-desk1) ([10.88.27.144]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2026 16:38:16 -0700 From: Vinicius Costa Gomes To: Jakub Kicinski , davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, jakub@cloudflare.com, maxime.chevallier@bootlin.com, nb@tipi-net.de, lee@kernel.org, linux-leds@vger.kernel.org, pavel@kernel.org, jv@jvosburgh.net, michael.chan@broadcom.com, jhs@mojatatu.com, idosch@nvidia.com, razor@blackwall.org, hare@suse.de, jhasan@marvell.com, danieller@nvidia.com, Jakub Kicinski Subject: Re: [PATCH net-next v2 08/11] net: sched: don't recurse on the netdev ops lock in qdiscs In-Reply-To: <20260603012840.2254293-9-kuba@kernel.org> References: <20260603012840.2254293-1-kuba@kernel.org> <20260603012840.2254293-9-kuba@kernel.org> Date: Thu, 04 Jun 2026 16:38:16 -0700 Message-ID: <87ldctq3kn.fsf@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Jakub Kicinski writes: > cbs_set_port_rate() and taprio_set_picos_per_byte() are reached from > two paths and both already hold the device's ops lock: > > *_change(), via tc_modify_qdisc() which calls netdev_lock_ops(dev) > before dispatching to the qdisc ops. > > *_dev_notifier() on NETDEV_UP / NETDEV_CHANGE, where caller > holds the ops lock across the notifier chain. > > Switch to netif_get_link_ksettings() to avoid deadlock once > __ethtool_get_link_ksettings() starts taking the netdev lock. > > Signed-off-by: Jakub Kicinski > --- Acked-by: Vinicius Costa Gomes Cheers, -- Vinicius