From: Peter Korsgaard <peter@korsgaard.com>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next] net: usb: sr9700: replace magic numbers with register bit macros
Date: Sat, 24 Jan 2026 11:25:40 +0100 [thread overview]
Message-ID: <87ldhns3x7.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20260124032248.26807-1-enelsonmoore@gmail.com> (Ethan Nelson-Moore's message of "Fri, 23 Jan 2026 19:22:43 -0800")
>>>>> "Ethan" == Ethan Nelson-Moore <enelsonmoore@gmail.com> writes:
> The first byte of the Rx frame is a copy of the Rx status register, so
> 0x40 corresponds to RSR_MF (meaning the frame is multicast). Replace
> 0x40 with RSR_MF for clarity. (All other bits of the RSR indicate
> errors. The fact that the driver ignores these errors will be fixed by
> a later patch.)
> The first byte of the status URB is a copy of the NSR, so 0x40
> corresponds to NSR_LINKST. Replace 0x40 with NSR_LINKST for clarity.
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
I don't know the device, but sounds sensible.
Reviewed-by: Peter Korsgaard <peter@korsgaard.com>
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2026-01-24 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-24 3:22 [PATCH net-next] net: usb: sr9700: replace magic numbers with register bit macros Ethan Nelson-Moore
2026-01-24 10:25 ` Peter Korsgaard [this message]
2026-01-28 0:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldhns3x7.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox