From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sendmail.purelymail.com (sendmail.purelymail.com [34.202.193.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03413239E8D for ; Sat, 24 Jan 2026 10:25:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=34.202.193.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769250345; cv=none; b=Zw8qA64qb/mPnvDSRe+JbWx0KI46l8fzXa2uUZ62D9xNGGf8UIFQwwAw8lMi4uV68q/S03VBcusJoB9XevMKmzxzA+y9yFMzlOZtYsX2DKbNQLiAQbSTTHD01I49b6OPW6RIzWFLw/z7wO9NOCY16xSGoVpEgajgA9SiiS8ocSQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769250345; c=relaxed/simple; bh=IiAcczMwwovguiLb7lLKzedLwywlNVBhDsNQvelPB0U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=cfR54EKCHN9AAiqSTZJt4F6e7N1/RNs1VJz8y4MGx4XVObUCm6b0IFve1SD6NHA21jcLvBUEF8d7xG6sdanG4Epm+teATCYHTgVmcnkw5NEq1qCcKrLaIblqowSkQuJ+GVfqBIlXrC+Cr6ekVKFIu6Ar1ZyWQrD8mXEFRXVO91U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=korsgaard.com; spf=pass smtp.mailfrom=korsgaard.com; dkim=pass (2048-bit key) header.d=purelymail.com header.i=@purelymail.com header.b=freSOQkZ; arc=none smtp.client-ip=34.202.193.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=korsgaard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purelymail.com header.i=@purelymail.com header.b="freSOQkZ" DKIM-Signature: a=rsa-sha256; b=freSOQkZVucMylTOiHsOyxxE9EEQrKOsPDxJqri4YtWTtBZCHHH2xSmTh0r8tP+dVbmJM3pIBO1EHMTkmzUn6EUg/+evaAgwvq+9TzkuRc+Fls5fhmquDAVcaG86J2hu9A4+fXVtT6geqGUL6e0h1QanrZI9TOgcyVceCY66m9a41xeQuIrHtojFPL87AuTQBfx90tr900ZnkjsS5g1nQHJPa0wo4n68htAFREYwnUXwGATplX6RecN48BdxUm2LJ0w0brqAEFj9CrbxIQIx1J9vIznnnjvT3HndnaVajlAZts1qswzgkom0RYsffNMD+hecNV/OIUSA4bfDDwgk6w==; s=purelymail1; d=purelymail.com; v=1; bh=IiAcczMwwovguiLb7lLKzedLwywlNVBhDsNQvelPB0U=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 21632:4007:null:purelymail X-Pm-Original-To: netdev@vger.kernel.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 323067734; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 24 Jan 2026 10:25:41 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.98.2) (envelope-from ) id 1vjapo-0000000GHQJ-0ipS; Sat, 24 Jan 2026 11:25:40 +0100 From: Peter Korsgaard To: Ethan Nelson-Moore Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Subject: Re: [PATCH net-next] net: usb: sr9700: replace magic numbers with register bit macros In-Reply-To: <20260124032248.26807-1-enelsonmoore@gmail.com> (Ethan Nelson-Moore's message of "Fri, 23 Jan 2026 19:22:43 -0800") References: <20260124032248.26807-1-enelsonmoore@gmail.com> Date: Sat, 24 Jan 2026 11:25:40 +0100 Message-ID: <87ldhns3x7.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain >>>>> "Ethan" == Ethan Nelson-Moore writes: > The first byte of the Rx frame is a copy of the Rx status register, so > 0x40 corresponds to RSR_MF (meaning the frame is multicast). Replace > 0x40 with RSR_MF for clarity. (All other bits of the RSR indicate > errors. The fact that the driver ignores these errors will be fixed by > a later patch.) > The first byte of the status URB is a copy of the NSR, so 0x40 > corresponds to NSR_LINKST. Replace 0x40 with NSR_LINKST for clarity. > Signed-off-by: Ethan Nelson-Moore I don't know the device, but sounds sensible. Reviewed-by: Peter Korsgaard -- Bye, Peter Korsgaard