netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Martin Zaharinov <micron10@gmail.com>, peterz@infradead.org
Cc: netdev <netdev@vger.kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	patchwork-bot+netdevbpf@kernel.org,
	Jakub Kicinski <kuba@kernel.org>,
	Stephen Hemminger <stephen@networkplumber.org>,
	kuba+netdrv@kernel.org, dsahern@gmail.com,
	Eric Dumazet <edumazet@google.com>
Subject: Re: Urgent Bug Report Kernel crash 6.5.2
Date: Fri, 08 Dec 2023 23:20:00 +0100	[thread overview]
Message-ID: <87lea4qqun.ffs@tglx> (raw)
In-Reply-To: <5E63894D-913B-416C-B901-F628BB6C00E0@gmail.com>

On Thu, Dec 07 2023 at 00:38, Martin Zaharinov wrote:
>> On 7 Dec 2023, at 0:26, Martin Zaharinov <micron10@gmail.com> wrote:
>> 
>> in this line is : 
>> 
>> 
>>        /*
>>         * If the reference count was already in the dead zone, then this
>>         * put() operation is imbalanced. Warn, put the reference count back to
>>         * DEAD and tell the caller to not deconstruct the object.
>>         */
>>        if (WARN_ONCE(cnt >= RCUREF_RELEASED, "rcuref - imbalanced put()")) {
>>                atomic_set(&ref->refcnt, RCUREF_DEAD);
>>                return false;
>>        }

So a rcuref_put() operation triggers the warning because the reference
count is already dead, which means the rcuref_put() operation is
imbalanced.

>> [529520.875413] CPU: 13 PID: 0 Comm: swapper/13 Tainted: G           O       6.6.3 #1

Can you reproduce this without the Out of Tree module?

>> [529520.875653] RIP: 0010:rcuref_put_slowpath+0x5f/0x70
>> [529520.878136]  dst_release+0x1c/0x40
>> [529520.878229]  __dev_queue_xmit+0x594/0xcd0
>> [529520.878324]  ? eth_header+0x25/0xc0
>> [529520.878417]  ip_finish_output2+0x1a0/0x530
>> [529520.878514]  process_backlog+0x107/0x210
>> [529520.878610]  __napi_poll+0x20/0x180
>> [529520.878702]  net_rx_action+0x29f/0x380
>> [529520.878935]  __do_softirq+0xd0/0x202
>> [529520.879033]  do_softirq+0x3a/0x50

So this is one call chain triggering the issue...

>>> report same problem with kernel 6.6.1 - i think problem is in rcu
>>> but … if have options to add people from RCU here.

That's definitely not a RCU problem. It's a simple refcount fail.

Thanks,

        tglx


  parent reply	other threads:[~2023-12-08 22:20 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15  4:05 Urgent Bug Report Kernel crash 6.5.2 Martin Zaharinov
2023-09-15  6:45 ` Eric Dumazet
2023-09-15 22:23   ` Martin Zaharinov
2023-11-16 14:17   ` Martin Zaharinov
2023-12-06 22:26     ` Martin Zaharinov
     [not found]       ` <5E63894D-913B-416C-B901-F628BB6C00E0@gmail.com>
2023-12-08 22:20         ` Thomas Gleixner [this message]
2023-12-08 23:01           ` Martin Zaharinov
2023-12-12 18:16             ` Thomas Gleixner
2023-12-19  9:25               ` Martin Zaharinov
2023-12-19 14:26                 ` Thomas Gleixner
2023-12-22 17:26                   ` Martin Zaharinov
2023-12-29 12:00                     ` Martin Zaharinov
2024-01-04 20:51                       ` Martin Zaharinov
2024-01-07 11:03                         ` Martin Zaharinov
2023-09-15 23:00 ` Martin Zaharinov
2023-09-15 23:11   ` Martin Zaharinov
2023-09-16  8:27     ` Paolo Abeni
     [not found]       ` <CALidq=UR=3rOHZczCnb1bEhbt9So60UZ5y60Cdh4aP41FkB5Tw@mail.gmail.com>
2023-09-17 11:35         ` Martin Zaharinov
2023-09-17 11:40         ` Martin Zaharinov
2023-09-17 11:55           ` Martin Zaharinov
2023-09-17 12:04             ` Holger Hoffstätte
2023-09-18  8:09             ` Eric Dumazet
2023-09-19 20:09             ` Martin Zaharinov
2023-09-20  3:59               ` Eric Dumazet
2023-09-20  6:05                 ` Martin Zaharinov
2023-09-20  6:16                   ` Bagas Sanjaya
2023-09-20  7:03                     ` Martin Zaharinov
2023-09-20  7:25                       ` Eric Dumazet
2023-09-20  7:29                         ` Eric Dumazet
2023-09-20  7:32                           ` Martin Zaharinov
2023-09-21  7:50                             ` Bagas Sanjaya
2023-09-21  8:13                               ` Martin Zaharinov
2023-09-22  3:06                                 ` Bagas Sanjaya
2023-09-22  9:50                                   ` Linux regression tracking (Thorsten Leemhuis)
2023-09-22 11:09                                     ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lea4qqun.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=dsahern@gmail.com \
    --cc=edumazet@google.com \
    --cc=kuba+netdrv@kernel.org \
    --cc=kuba@kernel.org \
    --cc=micron10@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=patchwork-bot+netdevbpf@kernel.org \
    --cc=peterz@infradead.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).