From: Kalle Valo <kvalo@kernel.org>
To: "Jérôme Pouiller" <jerome.pouiller@silabs.com>
Cc: cgel.zte@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Minghao Chi <chi.minghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] staging: wfx: Remove redundant NULL check before release_firmware() call
Date: Wed, 08 Jun 2022 11:02:27 +0300 [thread overview]
Message-ID: <87leu7shv0.fsf@kernel.org> (raw)
In-Reply-To: <5637060.DvuYhMxLoT@pc-42> ("Jérôme Pouiller"'s message of "Mon, 06 Jun 2022 08:36:37 +0200")
Jérôme Pouiller <jerome.pouiller@silabs.com> writes:
> On Monday 6 June 2022 03:42:37 CEST cgel.zte@gmail.com wrote:
>> From: Minghao Chi <chi.minghao@zte.com.cn>
>>
>> release_firmware() checks for NULL pointers internally so checking
>> before calling it is redundant.
>>
>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
[...]
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
I'll change this to Acked-by, s-o-b should be used only when you are
part of patch distribution:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
And please edit your quotes, otherwise using patchwork will be painful.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-06-08 8:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 1:42 [PATCH] staging: wfx: Remove redundant NULL check before release_firmware() call cgel.zte
2022-06-06 6:36 ` Jérôme Pouiller
2022-06-08 8:02 ` Kalle Valo [this message]
2022-06-10 7:39 ` wifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leu7shv0.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jerome.pouiller@silabs.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).