From: Kurt Kanzenbach <kurt@linutronix.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
Samuel Zou <zou_wei@huawei.com>,
Networking <netdev@vger.kernel.org>,
Petr Machata <petrm@mellanox.com>
Subject: Re: [PATCH v3 5/9] ethernet: ti: am65-cpts: Use generic helper function
Date: Fri, 31 Jul 2020 13:48:25 +0200 [thread overview]
Message-ID: <87lfiz29di.fsf@kurt> (raw)
In-Reply-To: <CAK8P3a2G7YJqzwrLDnDDO3ZUtNvyBSyun=6NjY3M2KS0Wr1ubg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]
On Thu Jul 30 2020, Arnd Bergmann wrote:
> On Thu, Jul 30, 2020 at 11:41 AM Kurt Kanzenbach <kurt@linutronix.de> wrote:
>> On Thu Jul 30 2020, Grygorii Strashko wrote:
>> > On 30/07/2020 11:00, Kurt Kanzenbach wrote:
>> >> + msgtype = ptp_get_msgtype(hdr, ptp_class);
>> >> + seqid = be16_to_cpu(hdr->sequence_id);
>> >
>> > Is there any reason to not use "ntohs()"?
>>
>> This is just my personal preference, because I think it's more
>> readable. Internally ntohs() uses be16_to_cpu(). There's no technical
>> reason for it.
>
> I think for traditional reasons, code in net/* tends to use ntohs()
> while code in drivers/* tends to use be16_to_cpu().
>
> In drivers/net/* the two are used roughly the same, though I guess
> one could make the argument that be16_to_cpu() would be
> more appropriate for data structures exchanged with hardware
> while ntohs() makes sense on data structures sent over the
> network.
I see, makes sense. I could simply keep it the way it was, or?
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-07-31 11:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 8:00 [PATCH v3 0/9] ptp: Add generic helper functions Kurt Kanzenbach
2020-07-30 8:00 ` [PATCH v3 1/9] ptp: Add generic ptp v2 header parsing function Kurt Kanzenbach
2020-07-30 10:15 ` Petr Machata
2020-07-31 10:06 ` Kurt Kanzenbach
2020-08-04 20:56 ` Grygorii Strashko
2020-08-04 21:07 ` Russell King - ARM Linux admin
2020-08-04 21:34 ` Grygorii Strashko
2020-08-04 21:44 ` Russell King - ARM Linux admin
2020-08-04 22:04 ` Grygorii Strashko
2020-08-04 23:14 ` Russell King - ARM Linux admin
2020-08-05 9:29 ` Kurt Kanzenbach
2020-08-05 12:59 ` Grygorii Strashko
2020-08-05 13:57 ` Kurt Kanzenbach
2020-08-05 19:15 ` Grygorii Strashko
2020-08-06 7:56 ` Kurt Kanzenbach
2020-08-05 15:25 ` Richard Cochran
2020-08-02 15:13 ` Richard Cochran
2020-08-02 20:20 ` Florian Fainelli
2020-07-30 8:00 ` [PATCH v3 2/9] ptp: Add generic ptp message type function Kurt Kanzenbach
2020-08-02 15:18 ` Richard Cochran
2020-08-02 20:20 ` Florian Fainelli
2020-07-30 8:00 ` [PATCH v3 3/9] net: dsa: mv88e6xxx: Use generic helper function Kurt Kanzenbach
2020-08-02 15:18 ` Richard Cochran
2020-08-02 20:21 ` Florian Fainelli
2020-07-30 8:00 ` [PATCH v3 4/9] mlxsw: spectrum_ptp: " Kurt Kanzenbach
2020-07-30 10:20 ` Petr Machata
2020-08-02 20:21 ` Florian Fainelli
2020-07-30 8:00 ` [PATCH v3 5/9] ethernet: ti: am65-cpts: " Kurt Kanzenbach
2020-07-30 9:19 ` Grygorii Strashko
2020-07-30 9:36 ` Kurt Kanzenbach
2020-07-30 10:24 ` Arnd Bergmann
2020-07-31 11:48 ` Kurt Kanzenbach [this message]
2020-07-31 12:55 ` Grygorii Strashko
2020-07-31 13:10 ` Kurt Kanzenbach
2020-07-30 8:00 ` [PATCH v3 6/9] ethernet: ti: cpts: " Kurt Kanzenbach
2020-08-02 20:22 ` Florian Fainelli
2020-08-05 18:52 ` Grygorii Strashko
2020-07-30 8:00 ` [PATCH v3 7/9] net: phy: dp83640: " Kurt Kanzenbach
2020-08-02 20:23 ` Florian Fainelli
2020-08-02 22:54 ` Richard Cochran
2020-07-30 8:00 ` [PATCH v3 8/9] ptp: ptp_ines: " Kurt Kanzenbach
2020-08-02 20:23 ` Florian Fainelli
2020-07-30 8:00 ` [PATCH v3 9/9] ptp: Remove unused macro Kurt Kanzenbach
2020-08-02 20:24 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfiz29di.fsf@kurt \
--to=kurt@linutronix.de \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=hkallweit1@gmail.com \
--cc=idosch@mellanox.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=richardcochran@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).