From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
David Ahern <dahern@digitalocean.com>
Cc: Jason Wang <jasowang@redhat.com>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: virtio_net: can change MTU after installing program
Date: Wed, 26 Feb 2020 10:51:33 +0100 [thread overview]
Message-ID: <87lfopznfe.fsf@toke.dk> (raw)
In-Reply-To: <7df5bb7f-ea69-7673-642b-f174e45a1e64@digitalocean.com>
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Tue, Feb 25, 2020 at 08:32:14PM -0700, David Ahern wrote:
>> Another issue is that virtio_net checks the MTU when a program is
>> installed, but does not restrict an MTU change after:
>>
>> # ip li sh dev eth0
>> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 xdp qdisc fq_codel
>> state UP mode DEFAULT group default qlen 1000
>> link/ether 5a:39:e6:01:a5:36 brd ff:ff:ff:ff:ff:ff
>> prog/xdp id 13 tag c5595e4590d58063 jited
>>
>> # ip li set dev eth0 mtu 8192
>>
>> # ip li sh dev eth0
>> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 8192 xdp qdisc fq_codel
>> state UP mode DEFAULT group default qlen 1000
>>
>>
>
> Cc Toke who has tested this on other cards and has some input.
Well, my comment was just that we already restrict MTU changes on mlx5
when an XDP program is loaded:
$ sudo ip link set dev ens1f1 mtu 8192
RTNETLINK answers: Invalid argument
Reading through the rest of the thread I don't have any strong opinions
about whether this should propagate out from the host or not. I suspect
it would not be worth the trouble, though, and as you say it's already
possible to configure regular network devices in a way that is
incompatible with the rest of the network.
-Toke
next prev parent reply other threads:[~2020-02-26 9:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 9:33 Michael S. Tsirkin
2020-02-26 3:32 ` virtio_net: can change MTU after installing program David Ahern
2020-02-26 4:02 ` Jason Wang
2020-02-26 4:31 ` David Ahern
2020-02-26 5:53 ` Jason Wang
2020-02-26 16:04 ` David Ahern
2020-02-26 7:07 ` Michael S. Tsirkin
2020-02-26 7:37 ` Jason Wang
2020-02-26 8:39 ` Michael S. Tsirkin
2020-02-26 9:30 ` Jason Wang
2020-02-26 9:36 ` Michael S. Tsirkin
2020-02-26 16:08 ` David Ahern
2020-02-26 16:56 ` Michael S. Tsirkin
2020-02-26 9:51 ` Toke Høiland-Jørgensen [this message]
2020-02-26 16:03 ` David Ahern
2020-02-26 16:55 ` Michael S. Tsirkin
2020-02-26 16:58 ` David Ahern
2020-02-26 17:02 ` Michael S. Tsirkin
2020-02-27 1:37 ` Jakub Kicinski
2020-02-27 8:14 ` Michael S. Tsirkin
2020-02-27 17:16 ` Jakub Kicinski
2020-02-27 19:26 ` Michael Chan
2020-02-27 19:45 ` Jakub Kicinski
2020-02-27 21:37 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfopznfe.fsf@toke.dk \
--to=toke@redhat.com \
--cc=dahern@digitalocean.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).