From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 574A5C2D0CD for ; Tue, 17 Dec 2019 14:35:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2EC5521D7D for ; Tue, 17 Dec 2019 14:35:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="c1/vcYQz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728146AbfLQOfO (ORCPT ); Tue, 17 Dec 2019 09:35:14 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:22279 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726402AbfLQOfN (ORCPT ); Tue, 17 Dec 2019 09:35:13 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1576593313; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=21aBxipy8p7uk0rKdijJDM9b/aNaNo4M823NpVdIVDU=; b=c1/vcYQzXgcN+KLbLvcUmAaILbamLfNxNqbvIRLYqRyCQQTcLp8E5cD47SvrceFXPEvBnfVl RArBVjlf2oo3+JGQxxwbVIqq9oDBy1hhaPKpYqwHkka39UMKNUoIf5Wg7ydciJeLltGMYtki 4dddhIEd/tU6Lpm3VhmsVNpQ+IM= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5df8e79f.7f9759a6a880-smtp-out-n01; Tue, 17 Dec 2019 14:35:11 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B324EC433A2; Tue, 17 Dec 2019 14:35:10 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6A0EEC43383; Tue, 17 Dec 2019 14:35:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6A0EEC43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arnd Bergmann Cc: Felix Fietkau , Lorenzo Bianconi , "David S. Miller" , Matthias Brugger , Ryder Lee , Roy Luo , Stanislaw Gruszka , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mt76: fix LED link time failure References: <20191216131902.3251040-1-arnd@arndb.de> Date: Tue, 17 Dec 2019 16:35:02 +0200 In-Reply-To: <20191216131902.3251040-1-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 16 Dec 2019 14:18:42 +0100") Message-ID: <87lfrbaull.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Arnd Bergmann writes: > The mt76_led_cleanup() function is called unconditionally, which > leads to a link error when CONFIG_LEDS is a loadable module or > disabled but mt76 is built-in: > > drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device': > mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister' > > Use the same trick that is guarding the registration, using an > IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates > whether LEDs can be used or not. > > Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev") > Signed-off-by: Arnd Bergmann Felix, as this is a regression in v5.5-rc1 can I take this directly to wireless-drivers? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches