netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Kevin 'ldir' Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
Cc: "netdev\@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v5] net: sched: Introduce act_ctinfo action
Date: Mon, 27 May 2019 22:56:12 +0200	[thread overview]
Message-ID: <87lfyrwr9v.fsf@toke.dk> (raw)
In-Reply-To: <4F2278CE-5197-43FF-B3D5-AF443088D73F@darbyshire-bryant.me.uk>

Kevin 'ldir' Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk> writes:

> I have to call it a day. I have no idea why the patches are becoming
> corrupt and hence how to fix it, it’s probably something Apple has
> done to git, or maybe MS to my email server.

Or maybe it's just that your editor saves things with the wrong type of
line ending (if you're on a Mac)?

> Sadly I also think that the only way this patch/functionality will
> ever be acceptable is if someone else writes it, where they or their
> company can take the credit/blame.

Not sure why you would think so.

> I tried very hard to approach the process of upstream submission in a
> positive way, seeking advice & guidance in the form of RFC patches,
> many rounds later I feel they’re further away from acceptance than
> ever.

Not sure why you'd think that either; I thought you were rather close,
actually...

> Clearly it is not desired functionality/code otherwise it would have
> been written by now and I cannot face another 3 rounds of the same
> thing for act_ctinfo user space, the x_tables/nf_tables kernel helper
> to store the DSCP in the first place and the user space code to handle
> that.
>
> As a rank outsider, amateur coder I shall leave it that I’ve found the
> process completely discouraging. The professionals are of course paid
> to deal with this.

It's up to you if you want to continue, of course; but honestly, I'm not
actually sure what it is you are finding hard to "deal with"? No one has
told you "go away, this is junk"; you've gotten a few suggestions for
improvements, most of which you have already fixed. So what, exactly, is
the problem? :)

-Toke

  reply	other threads:[~2019-05-27 20:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 16:09 [PATCH net-next v4] net: sched: Introduce act_ctinfo action Kevin 'ldir' Darbyshire-Bryant
2019-05-24 10:30 ` Toke Høiland-Jørgensen
2019-05-24 13:39   ` Kevin 'ldir' Darbyshire-Bryant
2019-05-24 14:24     ` Toke Høiland-Jørgensen
2019-05-27 11:17       ` [PATCH net-next v5] " Kevin 'ldir' Darbyshire-Bryant
2019-05-27 15:47         ` Toke Høiland-Jørgensen
2019-05-27 19:40           ` Kevin 'ldir' Darbyshire-Bryant
2019-05-27 20:56             ` Toke Høiland-Jørgensen [this message]
2019-05-29 10:20               ` Kevin 'ldir' Darbyshire-Bryant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfyrwr9v.fsf@toke.dk \
    --to=toke@redhat.com \
    --cc=ldir@darbyshire-bryant.me.uk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).