From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: trigger named just "tx" in drivers/net/wireless/atmel/at76c50x-usb.c Date: Mon, 03 Dec 2018 10:45:01 +0200 Message-ID: <87lg57f182.fsf@codeaurora.org> References: <20181201143144.GC31631@amd> Mime-Version: 1.0 Content-Type: text/plain Cc: jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org, kernel list , davem@davemloft.net, linux-wireless@vger.kernel.org, netdev@vger.kernel.org To: Pavel Machek Return-path: In-Reply-To: <20181201143144.GC31631@amd> (Pavel Machek's message of "Sat, 1 Dec 2018 15:31:44 +0100") Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Pavel Machek writes: > While grepping something else, I came across LED trigger that is named > just "tx". > > That's a bit too generic afaict? > > +++ b/drivers/net/wireless/atmel/at76c50x-usb.c > @@ -520,7 +520,7 @@ static int at76_usbdfu_download(struct usb_device > *udev, u8 *buf, u32 size, > static int tx_activity; > static void at76_ledtrig_tx_timerfunc(struct timer_list *unused); > static DEFINE_TIMER(ledtrig_tx_timer, at76_ledtrig_tx_timerfunc); > -DEFINE_LED_TRIGGER(ledtrig_tx); > +DEFINE_LED_TRIGGER(ledtrig_tx); /* Hey! "tx" is a bit too generic > name for a trigger! */ This is an ancient driver, my guess is that nobody uses it anymore. I should orphan it and maybe even remove it at some point. -- Kalle Valo