From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings Date: Wed, 25 Jul 2018 11:40:30 +0300 Message-ID: <87lg9zvhc1.fsf@kamboji.qca.qualcomm.com> References: <87lg9zyg1p.fsf@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain Cc: Arnd Bergmann , "Reizer\, Eyal" , Kees Cook , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com To: "H. Nikolaus Schaller" Return-path: In-Reply-To: (H. Nikolaus Schaller's message of "Wed, 25 Jul 2018 10:30:45 +0200") Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org "H. Nikolaus Schaller" writes: >> Am 25.07.2018 um 08:40 schrieb Kalle Valo : >> >> "H. Nikolaus Schaller" writes: >> >>> wl1271_warning() already appends a \n to the format, >>> so adding one to the warning string gives empty lines in the log. >>> >>> Signed-off-by: H. Nikolaus Schaller >> >> "drivers: net:" in the title is unnecessary, but I can remove that. > > Ok, thanks! I wasn't aware of the precise subsystem tagging style here. Yeah, subsystems can do it a bit differently. But you can easily check with git log the preferred style: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject -- Kalle Valo