From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinicius Costa Gomes Subject: RE: [Intel-wired-lan] [next-queue PATCH v5 7/9] igb: Add MAC address support for ethtool nftuple filters Date: Mon, 26 Mar 2018 16:55:39 -0700 Message-ID: <87lgeecryc.fsf@intel.com> References: <20180322003353.29970-1-vinicius.gomes@intel.com> <20180322003353.29970-8-vinicius.gomes@intel.com> <309B89C4C689E141A5FF6A0C5FB2118B8C81BBB3@ORSMSX101.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain Cc: "netdev\@vger.kernel.org" , "Sanchez-Palencia\, Jesus" To: "Brown\, Aaron F" , "intel-wired-lan\@lists.osuosl.org" Return-path: Received: from mga01.intel.com ([192.55.52.88]:31864 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249AbeCZXzk (ORCPT ); Mon, 26 Mar 2018 19:55:40 -0400 In-Reply-To: <309B89C4C689E141A5FF6A0C5FB2118B8C81BBB3@ORSMSX101.amr.corp.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi Aaron, "Brown, Aaron F" writes: > > Maybe not "this" patch, but this is the one that enables the ethtool commands, so replying here. > The filters do not seem to take effect with this version (v5) of the > series. The commands are accepted for i210 and rejected with > unsupported messages for the other adapters (as desired) and an > ethtool -n shows the filter, however, with either the src or dst > filter set I can run traffic (netperf) that should be caught by the > filter and rather than being directed to the single queue it is spread > across queues as would be expected without the filter set. > > The test system still has a kernel / driver with the v4 series of this > patch set and the exact same filter commands / system setup does > filter the traffic to the specified rx queue with the v4 series. That's interesting. The only difference is that now non steering filters (filters added by 'ip (m)addr', PACKET_ADD_MEMBERSHIP and the local MAC address, for example) do not have the QSEL bit set. On my tests I cannot detect any change in behaviour between those two versions of the series, for example. trying to add a filter for the local MAC address has no visible effect in both versions. (This raises a question: should this be an error, or should this override the default entry configuration, or this behaviour is fine?) Can you share more information about your tests? so I can reproduce it here. Thank you,