From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivien Didelot Subject: Re: [PATCH 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write} Date: Sat, 26 Mar 2016 15:37:32 -0400 Message-ID: <87lh55hvyb.fsf@ketchup.mtl.sfl> References: <1458951004-27424-1-git-send-email-patrick@puiterwijk.org> <56F5E9D1.9030909@roeck-us.net> <56F5F71B.3090703@roeck-us.net> <87vb49gkdo.fsf@ketchup.mtl.sfl> <20160326191844.GA5547@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain Cc: Guenter Roeck , Patrick Uiterwijk , davem@davemloft.net, linux@arm.linux.org.uk, netdev@vger.kernel.org, Dennis Gilmore , Peter Robinson To: Andrew Lunn Return-path: Received: from mail.savoirfairelinux.com ([208.88.110.44]:46358 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752874AbcCZThh (ORCPT ); Sat, 26 Mar 2016 15:37:37 -0400 In-Reply-To: <20160326191844.GA5547@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: Hi Andrew, Andrew Lunn writes: >> "error" definitely doesn't make sense, especially in case of success. If >> one has a better suggestion that "clear" for the label, I don't really >> mind. > > Hi Vivien, Guenter > > page_0 ? For some unjustified reasons I prefered single word labels, but multiple words will be cleared indeed. page_0 is fine. What about an even more explicit "clear_page_0" label? Thanks, Vivien