netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolai Stange <nicstange@gmail.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Nicolai Stange <nicstange@gmail.com>,
	David Miller <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	isdn@linux-pingi.de, Chen Gang <gang.chen.5i5j@gmail.com>,
	Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch
Date: Mon, 22 Jun 2015 14:36:11 +0200	[thread overview]
Message-ID: <87lhfbly2s.fsf@gmail.com> (raw)
In-Reply-To: <1434972453.4568.8.camel@chaos.site> (Jean Delvare's message of "Mon, 22 Jun 2015 13:27:33 +0200")

Jean Delvare <jdelvare@suse.de> writes:
> Le Sunday 21 June 2015 à 19:59 +0200, Nicolai Stange a écrit :
>> David Miller <davem@davemloft.net> writes:
>>> Applied, but we're long overdue for an across-the-board-available
>>> endianness Kconfig option that can flat out be used in these situations.
>>> The current way this is handled is at best, a mess.
>> 
>> Regarding the general Kconfig endianess symbol, I will do another patch
>> based on the information of
>>   git grep '_endian\.h' -- arch/
>> and supply every arch with either of CONFIG_CPU_{LITTLE,BIG}_ENDIAN if
>> lacking.
>
> Note that Chen Gang (Cc'd) attempted the same almost a year ago:
> http://patchwork.linux-mips.org/patch/7540/
> then:
> http://marc.info/?t=140958656400002&r=1&w=2
>
> The idea was great IMHO but it did not work out, and I can't remember
> why.

Thank you very much for this pointer, Jean!  I've read through these
threads and to summarize, some arch maintainers' main point against that
patchset is that (recent) drivers should generally support both, LE and
BE.

It is interesting to note that Chen Gang had already addressed the very
same issue (Hisax NetJet driver) by the far more general approach
proposed by David Miller here, namely by introducing an
"across-the-board-available endianess Kconfig option".

So unless you really want to have such an option and ping me, I will not
do another patch in the mood of Chen Gang's original one.

      reply	other threads:[~2015-06-22 12:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17  1:05 [PATCH] isdn: disable HiSax NetJet driver on microblaze arch Nicolai Stange
2015-06-17  6:53 ` Jean Delvare
2015-06-17 10:58   ` Nicolai Stange
2015-06-21 16:54 ` David Miller
2015-06-21 17:59   ` Nicolai Stange
2015-06-22 11:27     ` Jean Delvare
2015-06-22 12:36       ` Nicolai Stange [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lhfbly2s.fsf@gmail.com \
    --to=nicstange@gmail.com \
    --cc=davem@davemloft.net \
    --cc=gang.chen.5i5j@gmail.com \
    --cc=isdn@linux-pingi.de \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).