From: Kalle Valo <kvalo@codeaurora.org>
To: Okash Khawaja <okash.khawaja@gmail.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: adm8211: fix checkpatch error for trailing statements on next line
Date: Mon, 04 May 2015 15:42:04 +0300 [thread overview]
Message-ID: <87lhh4wm3n.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20150503104231.GA3607@bytefire-computer> (Okash Khawaja's message of "Sun, 3 May 2015 11:42:31 +0100")
Okash Khawaja <okash.khawaja@gmail.com> writes:
> This patch fixes the checkpatch.pl error:
>
> ERROR: trailing statements should be on next line
>
> More specifically, the fix has been applied to the four occurances of the error listed below.
>
> ERROR: trailing statements should be on next line
> #1101: FILE: drivers/net/wireless/adm8211.c:1101:
> + case 0x8: reg |= (0x1 << 14);
>
> ERROR: trailing statements should be on next line
> #1103: FILE: drivers/net/wireless/adm8211.c:1103:
> + case 0x16: reg |= (0x2 << 14);
>
> ERROR: trailing statements should be on next line
> #1105: FILE: drivers/net/wireless/adm8211.c:1105:
> + case 0x32: reg |= (0x3 << 14);
>
> ERROR: trailing statements should be on next line
> #1107: FILE: drivers/net/wireless/adm8211.c:1107:
> + default: reg |= (0x0 << 14);
>
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
> ---
> drivers/net/wireless/adm8211.c | 20 ++++++++++++--------
> 1 file changed, 12 insertions(+), 8 deletions(-)
The patch has incorrectly "staging:" prefix in the title, please fix
that. "adm8211:" is enough, you don't need anything for drivers in
drivers/net/wireless.
--
Kalle Valo
next prev parent reply other threads:[~2015-05-04 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-03 10:42 [PATCH] staging: adm8211: fix checkpatch error for trailing statements on next line Okash Khawaja
2015-05-04 12:42 ` Kalle Valo [this message]
[not found] ` <87lhh4wm3n.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2015-05-05 5:19 ` [PATCH v2] " Okash Khawaja
2015-05-05 5:30 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhh4wm3n.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=okash.khawaja@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).