From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kalle Valo <kvalo@qca.qualcomm.com>
Subject: Re: FIX ME locking is implemented?
Date: Sat, 22 Nov 2014 16:41:07 +0200
Message-ID: <87lhn38fi4.fsf@kamboji.qca.qualcomm.com>
References: <54709610.6020502@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
To: nick <xerofoify@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <54709610.6020502@gmail.com> (nick's message of "Sat, 22 Nov 2014
	08:56:32 -0500")
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

nick <xerofoify@gmail.com> writes:

> I am wondering why the fix me in the code below still exists as this
> code is clearly being locked properly with a spin lock on the lock
> related to the created linked list in this code.

It would be nice to mention what driver and file you are referring to.
So this is from ath6kl_tx_queue_full() in
drivers/net/wireless/ath/ath6kl/txrx.c.

> /* FIXME: Locking */
> spin_lock_bh(&ar->list_lock);
> list_for_each_entry(vif, &ar->vif_list, list) {
> 	if (vif->nw_type == ADHOC_NETWORK ||
>  			action != HTC_SEND_FULL_DROP) {
>                         spin_unlock_bh(&ar->list_lock);
>
>                          set_bit(NETQ_STOPPED, &vif->flags);
>                          netif_stop_queue(vif->ndev);
>
>                          return action;
>               }
>         }
>         spin_unlock_bh(&ar->list_lock);

Most probably someone just forgot to update the comment, patches welcome :)

-- 
Kalle Valo