From: Jakub Sitnicki <jakub@cloudflare.com>
To: Michal Luczaj <mhal@rbox.co>
Cc: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
Shuah Khan <shuah@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf 1/6] selftest/bpf: Support more socket types in create_pair()
Date: Tue, 30 Jul 2024 19:13:18 +0200 [thread overview]
Message-ID: <87mslyztu9.fsf@cloudflare.com> (raw)
In-Reply-To: <7ae7a77c-c5ce-4a09-8a6c-b3cd014220f3@rbox.co> (Michal Luczaj's message of "Fri, 26 Jul 2024 22:29:39 +0200")
On Fri, Jul 26, 2024 at 10:29 PM +02, Michal Luczaj wrote:
> On 7/26/24 19:23, Jakub Sitnicki wrote:
>> I was going to suggest that a single return path for success is better
>> than two (diff below), but I see that this is what you ended up with
>> after patch 6.
>>
>> So I think we can leave it as is.
>> [...]
>
> And speaking of which, would you rather have patch 1 and 6 squashed?
Don't have a straight answer, sorry . Would have to see if the diff is
clear enough after squashing it. Use your best judgement.
It's certainly fine with me to review the steps that were taken to
massage the code.
next prev parent reply other threads:[~2024-07-30 17:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 11:32 [PATCH bpf 0/6] selftest/bpf: Various sockmap-related fixes Michal Luczaj
2024-07-24 11:32 ` [PATCH bpf 1/6] selftest/bpf: Support more socket types in create_pair() Michal Luczaj
2024-07-26 17:23 ` Jakub Sitnicki
2024-07-26 20:29 ` Michal Luczaj
2024-07-30 17:13 ` Jakub Sitnicki [this message]
2024-07-31 10:05 ` Michal Luczaj
2024-07-24 11:32 ` [PATCH bpf 2/6] selftest/bpf: Socket pair creation, cleanups Michal Luczaj
2024-07-24 11:32 ` [PATCH bpf 3/6] selftest/bpf: Simplify inet_socketpair() and vsock_unix_redir_connectible() Michal Luczaj
2024-07-26 10:26 ` Michal Luczaj
2024-07-24 11:32 ` [PATCH bpf 4/6] selftest/bpf: Respect the sotype of af_unix redir tests Michal Luczaj
2024-07-24 11:32 ` [PATCH bpf 5/6] selftest/bpf: Exercise SOCK_STREAM unix_inet_redir_to_connected() Michal Luczaj
2024-07-24 11:32 ` [PATCH bpf 6/6] selftest/bpf: Introduce __attribute__((cleanup)) in create_pair() Michal Luczaj
2024-07-26 17:27 ` Jakub Sitnicki
2024-07-26 20:37 ` Michal Luczaj
2024-07-26 17:36 ` [PATCH bpf 0/6] selftest/bpf: Various sockmap-related fixes Jakub Sitnicki
2024-07-26 20:45 ` Michal Luczaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mslyztu9.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mhal@rbox.co \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).