From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33D8618A6B6 for ; Tue, 30 Jul 2024 17:13:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722359603; cv=none; b=SMTKg/Z+o6TwIJq0KyjaIVZhvfENdFoo/EmolPlP3p5F+QHOvNyVRUwcI1p4+EMJsN1yNdaPlJ+9BvnXD4Ft2HV/8PZFluwBFIO9DKBaAqpt+/0/4oFiM2ulxQInlgripGHKk3wgP2bV7i+Wqe+2KOaadmkXhwzgHA9B8+GraMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722359603; c=relaxed/simple; bh=GzimSGPp4Pj8GOfT5R+B7eU0TGFkgJ2E+BdZPdWVLYI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=i38uo2ZO3yhncFO82ygYHUfqjh7MYwL7MuB+FNv6/O8Sqar5nn6y8oHfaMXbch4ZfUTBaEqj2t9ozlroK1tjqDUz0kXlD45pMk5Tu8KQis0PSNjMHj3e3bmtCj8O6U2KwW15wG7WcJv+ggixL6T3Jc7bzuIA3NIMEjBis4k9mwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=FNZMc9vF; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="FNZMc9vF" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a7ab63a388bso379480466b.1 for ; Tue, 30 Jul 2024 10:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1722359600; x=1722964400; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8m0nShPnuINbCdjeY7nEN4rJqDqmHY1w1WDR0g7gvAM=; b=FNZMc9vFUzMnAm6m02CxzK5fiUopr368ph5r15TjjQcmEh9KQYLiGsl1+Iv4ddulJY Yt5kPr4+sedfa9JwHQMkANRMjV1NrP/UGZlYvRyQldkXpyS21xWLFimTY/tssXdn6t65 W92k8ZDYOc+thywbBRfLXVxBiNUj1Xpn1xAHcSYmdGzi9LuOVBo2XxNWbP0beReVAPRR pTeDMqeDMd/r9SIDXF1m4BSapXjnw0wbzqhcDFyPw0Lw0yaSo9cRaWG6at/OW0nmOUp+ tyT1R+aQ0KSMp2NLsqhPGGNSsU4axNSRxX9XKsEKy6NAVPi9fiBIk5Ba/jfvt53XgNeU LMLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722359600; x=1722964400; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8m0nShPnuINbCdjeY7nEN4rJqDqmHY1w1WDR0g7gvAM=; b=hcmcqUZhazhv10JU8ltOYaIa/gKOuK6RD7UYMYyi1SvPgCoduOU8glnEsScmi/Qdrd SK40cEuaoMKuef7fzX6x2EE+Nv3nuZBXfkGGN2OJY3LTEFattURDSAoKwzMMUqGZJA3x LiVoM8IFSxZiASl/O/IBZWrgB3SCQ9nHWT/Kpjm7ye8fDMfajBLHZKng9R60J6cEqnnw d64l7MeJmyP+LEhsOybYmimMuYWE9i2+qR6qZGd9RfrpIXexBf7QHmNxLG1Z3N+bFviZ FS7gEidpEfq5vafFWSL55rZXaQpUgDNdwTlzTdurm+SPl4CR39qVz7DGaxnFkoJxkzqQ qPdw== X-Forwarded-Encrypted: i=1; AJvYcCXw8+5guNo80xvFFHFses+rF3P0zD/72gOOkyb6eSX4r+T6oZxmln9JtgfMsWMw7wlbfuwyK4t9N+wJw5RQDVysy16N3Vi1 X-Gm-Message-State: AOJu0YyPn/kkB+pZkjSE08PLVz6s3647GnY4OkistG2BDx4O9w8dUQTW bZxOrEc4XvpmY5oPzetHBrDMg0nEyry8M2tGBIcOOi+hJrGc0hCh+EqeInJsRhk= X-Google-Smtp-Source: AGHT+IGkt1E+D2BdP4URH/gGZVLCq5xWR4UWldftuqBSyxAPfGBZxzjaW//v+4HpwiJK/1dy4xQZgg== X-Received: by 2002:a05:6402:50c7:b0:5a0:f9f7:6565 with SMTP id 4fb4d7f45d1cf-5b021e1745dmr11214748a12.21.1722359600380; Tue, 30 Jul 2024 10:13:20 -0700 (PDT) Received: from cloudflare.com ([2a09:bac5:5063:2387::38a:2f]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac631b03ccsm7466835a12.16.2024.07.30.10.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jul 2024 10:13:19 -0700 (PDT) From: Jakub Sitnicki To: Michal Luczaj Cc: Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH bpf 1/6] selftest/bpf: Support more socket types in create_pair() In-Reply-To: <7ae7a77c-c5ce-4a09-8a6c-b3cd014220f3@rbox.co> (Michal Luczaj's message of "Fri, 26 Jul 2024 22:29:39 +0200") References: <20240724-sockmap-selftest-fixes-v1-0-46165d224712@rbox.co> <20240724-sockmap-selftest-fixes-v1-1-46165d224712@rbox.co> <87cyn0kqxu.fsf@cloudflare.com> <7ae7a77c-c5ce-4a09-8a6c-b3cd014220f3@rbox.co> User-Agent: mu4e 1.12.4; emacs 29.1 Date: Tue, 30 Jul 2024 19:13:18 +0200 Message-ID: <87mslyztu9.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, Jul 26, 2024 at 10:29 PM +02, Michal Luczaj wrote: > On 7/26/24 19:23, Jakub Sitnicki wrote: >> I was going to suggest that a single return path for success is better >> than two (diff below), but I see that this is what you ended up with >> after patch 6. >> >> So I think we can leave it as is. >> [...] > > And speaking of which, would you rather have patch 1 and 6 squashed? Don't have a straight answer, sorry . Would have to see if the diff is clear enough after squashing it. Use your best judgement. It's certainly fine with me to review the steps that were taken to massage the code.