From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C750412DDB2; Mon, 25 Mar 2024 14:01:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711375304; cv=none; b=ZRtXmcciNCS6rTE4+Dp2hAWOhgP6aO8dKR4eY9xnVLqK6Oikp0p9l1QPt9F2tFUq9lxFb1brKYmTSGjGpcDFapCyKCjFbwJD18UbF0BHu8NwXCtSXSrTkucXkmykacDx68nF9j5PR29H/ztert6NV+jOfCPY2ljTvw/mO8wSqmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711375304; c=relaxed/simple; bh=DO7jBH35/9WDTi4g3mhk+XjVvY8I/yCvQNhtDF49C3Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=BW4lmgHytmqsEvliqe6HJC15ItSC8JJA89rZ4J0fksHMaWc2uMTWKFFNpqBjFsgVKeD/KOCjL7HsdeeP06V/VfySFjv4g8ZD4JJQ65acUQeU+l5sR8vlCVsrQZSOI5p+s/GeJeq5FUpLi+LTfcSEcFTCcFVIHyJKDMMh1EJvRiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NbuS3/n5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NbuS3/n5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90712C433C7; Mon, 25 Mar 2024 14:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711375303; bh=DO7jBH35/9WDTi4g3mhk+XjVvY8I/yCvQNhtDF49C3Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=NbuS3/n5VaJ3t+uqiUn8hjAphJOP6TrrhjpklOG7s+HEHCvy+brGcrw7drMMfhZyH 3NGmYhv2ffnscuPpXBo2fsDUb03qsxtnR1/FQ6wb0zgJfel0YhFBQ+JF9R7SOnU6EP rhJZtHgrpC+fOTyOCGBhe67ss7mHyEk2OlLi+PsonIHbkbrFvjFYP1dGy8JeuSe86Z geJjzBaFG0ReAmT1PJGivL5pbXtJwPjdTNwxlAc2Dpx1oksqaeXxkDFCyzQCn6hc8C 9OrnK3dCRXAjTI010gcSTZoSSRkD68anC+i37dBeW7KnyCoIepm8mkxtLZlnt6GAht xBjBjIDOXz4MQ== From: Kalle Valo To: Bartosz Golaszewski Cc: Marcel Holtmann , Luiz Augusto von Dentz , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Catalin Marinas , Will Deacon , Bjorn Helgaas , Saravana Kannan , Geert Uytterhoeven , Arnd Bergmann , Neil Armstrong , Marek Szyprowski , Alex Elder , Srini Kandagatla , Greg Kroah-Hartman , Abel Vesa , Manivannan Sadhasivam , Lukas Wunner , Dmitry Baryshkov , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v6 05/16] dt-bindings: net: wireless: describe the ath12k PCI module References: <20240325131624.26023-1-brgl@bgdev.pl> <20240325131624.26023-6-brgl@bgdev.pl> Date: Mon, 25 Mar 2024 16:01:33 +0200 In-Reply-To: <20240325131624.26023-6-brgl@bgdev.pl> (Bartosz Golaszewski's message of "Mon, 25 Mar 2024 14:16:13 +0100") Message-ID: <87msqm8l6q.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Bartosz Golaszewski writes: > From: Bartosz Golaszewski > > Add device-tree bindings for the ATH12K module found in the WCN7850 > package. > > Signed-off-by: Bartosz Golaszewski > --- > .../bindings/net/wireless/qcom,ath12k.yaml | 100 ++++++++++++++++++ > 1 file changed, 100 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml > new file mode 100644 > index 000000000000..c0aad4815953 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml > @@ -0,0 +1,100 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2024 Linaro Limited > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies ath12k wireless devices (PCIe) > + > +maintainers: > + - Bartosz Golaszewski IMHO it would be better to have just driver maintainers listed here. > + - Jeff Johnson > + - Kalle Valo > + > +description: > + Qualcomm Technologies IEEE 802.11ax PCIe devices. > + > +properties: > + compatible: > + enum: > + - pci17cb,1107 # WCN7850 > + > + reg: > + maxItems: 1 > + > + vddaon-supply: > + description: VDD_AON supply regulator handle > + > + vddwlcx-supply: > + description: VDD_WLCX supply regulator handle > + > + vddwlmx-supply: > + description: VDD_WLMX supply regulator handle > + > + vddrfacmn-supply: > + description: VDD_RFA_CMN supply regulator handle > + > + vddrfa0p8-supply: > + description: VDD_RFA_0P8 supply regulator handle > + > + vddrfa1p2-supply: > + description: VDD_RFA_1P2 supply regulator handle > + > + vddrfa1p8-supply: > + description: VDD_RFA_1P8 supply regulator handle > + > + vddpcie0p9-supply: > + description: VDD_PCIE_0P9 supply regulator handle > + > + vddpcie1p8-supply: > + description: VDD_PCIE_1P8 supply regulator handle > + > +required: > + - compatible > + - reg > + - vddaon-supply > + - vddwlcx-supply > + - vddwlmx-supply > + - vddrfacmn-supply > + - vddrfa0p8-supply > + - vddrfa1p2-supply > + - vddrfa1p8-supply > + - vddpcie0p9-supply > + - vddpcie1p8-supply Same comment here as in patch 4. There are also ath12k PCI devices which don't need DT at all. I don't know if that should be reflected in the bindings doc but I want to point out this. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches