From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEE4017D0 for ; Mon, 8 May 2023 14:57:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25E4AC433EF; Mon, 8 May 2023 14:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683557867; bh=jpGRNu5+FvMQ20aEk+IlpTRzk8prDExhd+C0AMyLLyw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=anFJPecn/2S9eutk1Qd8p9EpzhLZTKjmEO6uDDAdmhnwqPwjC+Dc649EeATu+fW8r Lg03ejDhC2ypyNUTlQLqxMQyTrheCnxW9JNKqZ/QoLxxtg7k0ApxR63q0W9VEJhWWP m6bkgHqadtNE7lgaBMn+tvwFBbEBknyO1KrWqs1zMw4qkR7JHX/HmVnrfo6f7NDVkR f2i2wP6rKemgcTqz6COJVNofUvu/7lenlrfMXAECq8mpwJMC9uCVAaryQM9yCxUxhM gYP/Q0rVA0VyUYL0rrCee3i1S5oCGtxI7dZ0mXD2A3yR2NTTm1O/IoYkw0kaTkpMYH RnyR+vcJ8SGhw== From: Kalle Valo To: "Arnd Bergmann" Cc: "Arnd Bergmann" , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Johannes Berg" , "Manikanta Pubbisetty" , "Wen Gong" , "Baochen Qiang" , "Sowmiya Sree Elavalagan" , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, Netdev , linux-kernel@vger.kernel.org, ath12k@lists.infradead.org Subject: Re: [PATCH] wireless: ath: work around false-positive stringop-overread warning References: <20230417205447.1800912-1-arnd@kernel.org> <87ttwnnrer.fsf@kernel.org> <504c5a7d-0bfd-4b1e-a7f0-65d072657e0a@app.fastmail.com> Date: Mon, 08 May 2023 17:57:39 +0300 In-Reply-To: <504c5a7d-0bfd-4b1e-a7f0-65d072657e0a@app.fastmail.com> (Arnd Bergmann's message of "Mon, 08 May 2023 10:52:11 +0200") Message-ID: <87mt2eoopo.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Arnd Bergmann" writes: > On Mon, May 8, 2023, at 10:44, Kalle Valo wrote: > >> Arnd Bergmann writes: >> >>> From: Arnd Bergmann >>> >>> In a rare arm64 randconfig build, I got multiple warnings for ath11k >>> and ath12k: >>> >>> In function 'ath11k_peer_assoc_h_ht', >>> inlined from 'ath11k_peer_assoc_prepare' at drivers/net/wireless/ath/ath11k/mac.c:2665:2: >>> drivers/net/wireless/ath/ath11k/mac.c:1709:13: error: 'ath11k_peer_assoc_h_ht_masked' reading 10 bytes from a region of size 0 [-Werror=stringop-overread] >>> 1709 | if (ath11k_peer_assoc_h_ht_masked(ht_mcs_mask)) >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> This happens whenever gcc-13 fails to inline one of the functions >>> that take a fixed-length array argument but gets passed a pointer. >>> >>> Change these functions to all take a regular pointer argument >>> instead. >>> >>> Signed-off-by: Arnd Bergmann >> >> s/wireless:/wifi:/ but I can fix that. > > Ok, thanks! > >> In a awat it's a shame to lose the explicit length but I guess there's >> no other way to fix this? > > There might be, but I couldn't figure out a way that works. Ok. >> Also I hope you find the time to add GCC 13 to crosstool :) Related to >> this > > I uploaded gcc-13.1.0 binaries last week, but still need to > update the html page, so it's not yet linked. You can navigate > the directories from the gcc-12 builds. Thanks! I was able to find the build[1] but having an issue: $ ./x86_64-linux-gcc -v ./x86_64-linux-gcc: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.35' not found (required by ./x86_64-linux-gcc) ./x86_64-linux-gcc: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by ./x86_64-linux-gcc) ./x86_64-linux-gcc: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by ./x86_64-linux-gcc) ./x86_64-linux-gcc: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.36' not found (required by ./x86_64-linux-gcc) ./x86_64-linux-gcc: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by ./x86_64-linux-gcc) With older GCC versions from your page I don't have this problem. I'm using Debian 10 still so so is my libc too old? ii libc6:amd64 2.28-10+deb10u2:amd6 GNU C Library: Shared libraries [1] https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/13.1.0/x86_64-gcc-13.1.0-nolibc-x86_64-linux.tar.gz -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches