* [PATCH] igc: updated TX timestamp support for non-MSI-X platforms
@ 2021-12-17 20:52 James McLaughlin
2021-12-17 21:10 ` Vinicius Costa Gomes
2021-12-28 7:47 ` [Intel-wired-lan] " Kraus, NechamaX
0 siblings, 2 replies; 3+ messages in thread
From: James McLaughlin @ 2021-12-17 20:52 UTC (permalink / raw)
To: davem, kuba, jesse.brandeburg, anthony.l.nguyen
Cc: intel-wired-lan, netdev, linux-kernel, vinicius.gomes,
James McLaughlin
Time synchronization was not properly enabled on non-MSI-X platforms.
Signed-off-by: James McLaughlin <james.mclaughlin@qsc.com>
Reviewed-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
---
drivers/net/ethernet/intel/igc/igc_main.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 8e448288ee26..d28a80a00953 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -5467,6 +5467,9 @@ static irqreturn_t igc_intr_msi(int irq, void *data)
mod_timer(&adapter->watchdog_timer, jiffies + 1);
}
+ if (icr & IGC_ICR_TS)
+ igc_tsync_interrupt(adapter);
+
napi_schedule(&q_vector->napi);
return IRQ_HANDLED;
@@ -5510,6 +5513,9 @@ static irqreturn_t igc_intr(int irq, void *data)
mod_timer(&adapter->watchdog_timer, jiffies + 1);
}
+ if (icr & IGC_ICR_TS)
+ igc_tsync_interrupt(adapter);
+
napi_schedule(&q_vector->napi);
return IRQ_HANDLED;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] igc: updated TX timestamp support for non-MSI-X platforms
2021-12-17 20:52 [PATCH] igc: updated TX timestamp support for non-MSI-X platforms James McLaughlin
@ 2021-12-17 21:10 ` Vinicius Costa Gomes
2021-12-28 7:47 ` [Intel-wired-lan] " Kraus, NechamaX
1 sibling, 0 replies; 3+ messages in thread
From: Vinicius Costa Gomes @ 2021-12-17 21:10 UTC (permalink / raw)
To: James McLaughlin, davem, kuba, jesse.brandeburg, anthony.l.nguyen
Cc: intel-wired-lan, netdev, linux-kernel, James McLaughlin
Hi James,
James McLaughlin <james.mclaughlin@qsc.com> writes:
> Time synchronization was not properly enabled on non-MSI-X platforms.
>
> Signed-off-by: James McLaughlin <james.mclaughlin@qsc.com>
> Reviewed-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
A couple of things that I should have pointed out earlier.
The subject line would be better if it was: "PATCH net" (to indicate
that the patch should be considered for the "net" tree, not "net-next").
Also, it could be made clearer that it's a fix, so the full subject line
could be like this:
"[PATCH net] igc: Fix TX timestamp support for non-MSI platforms"
Adding a "fixes" tag to the commit message would help, something like this:
Fixes: 2c344ae24501 ("igc: Add support for TX timestamping")
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index 8e448288ee26..d28a80a00953 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -5467,6 +5467,9 @@ static irqreturn_t igc_intr_msi(int irq, void *data)
> mod_timer(&adapter->watchdog_timer, jiffies + 1);
> }
>
> + if (icr & IGC_ICR_TS)
> + igc_tsync_interrupt(adapter);
> +
> napi_schedule(&q_vector->napi);
>
> return IRQ_HANDLED;
> @@ -5510,6 +5513,9 @@ static irqreturn_t igc_intr(int irq, void *data)
> mod_timer(&adapter->watchdog_timer, jiffies + 1);
> }
>
> + if (icr & IGC_ICR_TS)
> + igc_tsync_interrupt(adapter);
> +
> napi_schedule(&q_vector->napi);
>
> return IRQ_HANDLED;
> --
> 2.25.1
>
Cheers,
--
Vinicius
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Intel-wired-lan] [PATCH] igc: updated TX timestamp support for non-MSI-X platforms
2021-12-17 20:52 [PATCH] igc: updated TX timestamp support for non-MSI-X platforms James McLaughlin
2021-12-17 21:10 ` Vinicius Costa Gomes
@ 2021-12-28 7:47 ` Kraus, NechamaX
1 sibling, 0 replies; 3+ messages in thread
From: Kraus, NechamaX @ 2021-12-28 7:47 UTC (permalink / raw)
To: James McLaughlin, davem, kuba, jesse.brandeburg, anthony.l.nguyen
Cc: netdev, intel-wired-lan, linux-kernel
On 12/17/2021 22:52, James McLaughlin wrote:
> Time synchronization was not properly enabled on non-MSI-X platforms.
>
> Signed-off-by: James McLaughlin <james.mclaughlin@qsc.com>
> Reviewed-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Tested-by: Nechama Kraus <nechamax.kraus@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-28 7:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-17 20:52 [PATCH] igc: updated TX timestamp support for non-MSI-X platforms James McLaughlin
2021-12-17 21:10 ` Vinicius Costa Gomes
2021-12-28 7:47 ` [Intel-wired-lan] " Kraus, NechamaX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).