From: Petr Machata <petrm@mellanox.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>,
David Ahern <dsahern@gmail.com>, Jiri Pirko <jiri@mellanox.com>
Subject: Re: [PATCH iproute2-next v2 2/2] tc: q_red: Implement has_block for RED
Date: Thu, 16 Jul 2020 18:37:22 +0200 [thread overview]
Message-ID: <87mu3zifgd.fsf@mellanox.com> (raw)
In-Reply-To: <20200716160729.GC23663@nanopsycho.orion>
Jiri Pirko <jiri@resnulli.us> writes:
> Thu, Jul 16, 2020 at 05:49:46PM CEST, petrm@mellanox.com wrote:
>>In order for "tc filter show block X" to find a given block, implement the
>>has_block callback.
>>
>>Signed-off-by: Petr Machata <petrm@mellanox.com>
>
> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Actually it's broken. When there are several qdiscs, the latter one's
result overwrites the previous one.
next prev parent reply other threads:[~2020-07-16 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 15:49 [PATCH iproute2-next v2 0/2] Support showing a block bound by qevent Petr Machata
2020-07-16 15:49 ` [PATCH iproute2-next v2 1/2] tc: Look for blocks in qevents Petr Machata
2020-07-16 16:07 ` Jiri Pirko
2020-07-16 15:49 ` [PATCH iproute2-next v2 2/2] tc: q_red: Implement has_block for RED Petr Machata
2020-07-16 16:07 ` Jiri Pirko
2020-07-16 16:37 ` Petr Machata [this message]
2020-07-16 16:52 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu3zifgd.fsf@mellanox.com \
--to=petrm@mellanox.com \
--cc=dsahern@gmail.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).