From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE29C76186 for ; Sat, 20 Jul 2019 19:34:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E3372085A for ; Sat, 20 Jul 2019 19:34:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726180AbfGTTet (ORCPT ); Sat, 20 Jul 2019 15:34:49 -0400 Received: from albireo.enyo.de ([5.158.152.32]:37712 "EHLO albireo.enyo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725940AbfGTTes (ORCPT ); Sat, 20 Jul 2019 15:34:48 -0400 Received: from [172.17.203.2] (helo=deneb.enyo.de) by albireo.enyo.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1hov80-0005v7-Fe; Sat, 20 Jul 2019 19:34:44 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.92) (envelope-from ) id 1hov80-0004M4-AR; Sat, 20 Jul 2019 21:34:44 +0200 From: Florian Weimer To: Arnd Bergmann Cc: Sergei Trofimovich , Networking , Linux Kernel Mailing List , GNU C Library , "David S. Miller" , Michael Kerrisk , linux-man Subject: Re: linux-headers-5.2 and proper use of SIOCGSTAMP References: <20190720174844.4b989d34@sf> <87wogca86l.fsf@mid.deneb.enyo.de> Date: Sat, 20 Jul 2019 21:34:44 +0200 In-Reply-To: (Arnd Bergmann's message of "Sat, 20 Jul 2019 20:50:23 +0200") Message-ID: <87muh8a4a3.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org * Arnd Bergmann: > On Sat, Jul 20, 2019 at 8:10 PM Florian Weimer wrote: >> >> * Sergei Trofimovich: >> >> > Should #include always be included by user app? >> > Or should glibc tweak it's definition of '#include ' >> > to make it available on both old and new version of linux headers? >> >> What is the reason for dropping SIOCGSTAMP from ? >> >> If we know that, it will be much easier to decide what to do about >> . > > As far as I can tell, nobody thought it would be a problem to move it > from asm/sockios.h to linux/sockios.h, as the general rule is that one > should use the linux/*.h version if both exist, and that the asm/*.h > version only contains architecture specific definitions. The new > definition is the same across all architectures, so it made sense to > have it in the common file. Most of the socket-related constants are not exposed in UAPI headers, although userspace is expected to use them. It seems to me that due to the lack of other options among the UAPI headers, has been a dumping ground for various socket-related things in the past, whether actually architecture-specific or not. does not include , so that's why we usually end up with including (perhaps indirectly via ), which used to include on most (all?) architectures. That in turn provided some of the SIOC* constants in the past, so people didn't investigate other options. I think we can change glibc to include in addition to . looks reasonably clean to me, much better than . I'm still working on the other breakage, and I'm severely limited by the machine resources I have access to.